refactor!: generalize STG to MutableTransition #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING: this removes the __post_init__ check, but this didn't seem to be doing anything anyway. Initially, I simply renamed the check __attrs_post_init__, but this actually does perform the check and then the system crashes. This seems to be an issue that needs to be addressed separately.
…Solution, InitialFacts
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
redeboer
force-pushed
the
Transition
branch
3 times, most recently
from
9499fe3 to
dfb288b
Compare
|
Apparently, Python 3.6 cannot work well with generic abstract base classes. Before 140843a: After 140843a: ...this again indicates we should drop support for Python 3.6. |
redeboer
changed the title
This was referenced Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All classes that map properties onto a
Topologyare now aTransition. A distinction is made betweenMutableTransition(for instance, the originalStateTransitionGraph) and aFrozenTransition(hashable and ordered―the originalStateTransitionclass).New design can best be read about in the renewed API of the
qrules.topologymodule.