Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to nbmake #359

Merged
merged 4 commits into from
Dec 1, 2021
Merged

ci: switch to nbmake #359

merged 4 commits into from
Dec 1, 2021

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Dec 1, 2021

Switch from pytest-notebook to nbmake. Now it's again possible to run specific notebooks from the terminal with e.g.:

pytest --nbmake docs/usage/basics.ipynb

Other small fixes:

  • Avoid fast_lambdify() in Jupyter notebooks to speed up docs workflow.
  • Cast to tuple in ParametrizedBackendFunction.

@redeboer redeboer added 📝 Docs Improvements or additions to documentation 🖱️ DX Improvements to the Developer Experience labels Dec 1, 2021
@redeboer redeboer added this to the 0.4.0 milestone Dec 1, 2021
@redeboer redeboer self-assigned this Dec 1, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -89,7 +89,6 @@
" expression=model.expression.doit(),\n",
" parameters=model.parameter_defaults,\n",
" backend=\"jax\",\n",
" max_complexity=100,\n",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Leongrim this may be of importance to your benchmark comparison. (See also #103)

@redeboer redeboer merged commit 5bdf32c into main Dec 1, 2021
@redeboer redeboer deleted the nbmake branch December 1, 2021 08:18
redeboer added a commit to redeboer/ComPWA-tensorwaves that referenced this pull request Dec 1, 2021
redeboer added a commit that referenced this pull request Dec 7, 2021
* ci: switch to nbmake
* ci: update pip constraints and pre-commit config
* docs: remove max_complexity from step 3
* fix: cast argument order to tuple

Co-authored-by: GitHub <noreply@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Docs Improvements or additions to documentation 🖱️ DX Improvements to the Developer Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants