-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch to nbmake #359
Merged
ci: switch to nbmake #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest-notebook does not work well, see e.g. ComPWA/compwa.github.io#49
redeboer
added
📝 Docs
Improvements or additions to documentation
🖱️ DX
Improvements to the Developer Experience
labels
Dec 1, 2021
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
redeboer
commented
Dec 1, 2021
@@ -89,7 +89,6 @@ | |||
" expression=model.expression.doit(),\n", | |||
" parameters=model.parameter_defaults,\n", | |||
" backend=\"jax\",\n", | |||
" max_complexity=100,\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redeboer
added a commit
to redeboer/ComPWA-tensorwaves
that referenced
this pull request
Dec 1, 2021
Reverts a change introduced in ComPWA#359
This was referenced Dec 1, 2021
redeboer
added a commit
that referenced
this pull request
Dec 7, 2021
* ci: switch to nbmake * ci: update pip constraints and pre-commit config * docs: remove max_complexity from step 3 * fix: cast argument order to tuple Co-authored-by: GitHub <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
pytest-notebook
tonbmake
. Now it's again possible to run specific notebooks from the terminal with e.g.:Other small fixes:
fast_lambdify()
in Jupyter notebooks to speed up docs workflow.tuple
inParametrizedBackendFunction
.