fix: jit-compile recombined fast_lambdify function #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping returned by split_expression did not cover all free symbols in the top expression. This caused issues in fast_lambdify when lambdifying that top expression.
Reverts a change introduced in ComPWA#359
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
redeboer
force-pushed
the
speed-up-fast-lambdify
branch
from
2b5c92e to
b920c77
Compare
redeboer
changed the title
redeboer
changed the title
redeboer
changed the title
redeboer
changed the title
redeboer
added a commit
that referenced
this pull request
Dec 7, 2021
* docs: use fast lambdify in usage notebook step 3 * fix: add remaining symbols to sub_expression dict * fix: include min and max in complexity interval * fix: jit-compile recombined fast_lambdify function * fix: return unsplit expression if max_complexity is 0 * refactor: extract jit_compile function * style: improve function order definition in sympy module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#348 introduced a bug: the recombined function was not JIT-compiled, which significantly slowed down performance. This was temporarily avoided in #359.