🧪 Bring over StackedNotificationsBehavior from Toolkit #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hawker
added
the
experiment 🧪
michael-hawker
force-pushed
the
llama/port-notifications
branch
from
c8cc172 to
425adcd
Compare
michael-hawker
commented
Jul 20, 2022
| Title = "Windows Community Toolkit Labs Sample App", | ||
| Content = $"Link {e.Link} was malformed.", | ||
| CloseButtonText = "Close", | ||
| XamlRoot = XamlRoot |
There was a problem hiding this comment.
Apparently, this only works on UWP for 1903+, so we'll need to figure out something for 1809 in the future, won't worry about it now.
michael-hawker
force-pushed
the
llama/port-notifications
branch
3 times, most recently
from
df5f789 to
09f4713
Compare
michael-hawker
changed the title
|
Bubbling up the CI Uno error here: Seems internal, but also going to rebase the branch and try rebuilding now that we fixed the SG test issue. |
michael-hawker
force-pushed
the
llama/port-notifications
branch
from
09f4713 to
137df39
Compare
|
Rebased, we'll see what happens now. |
|
Hmm, just checked the path specified here: |
This was referenced Jul 20, 2022
|
Uno folks pointed us to this issue: dotnet/msbuild#53 (comment) I'm wondering if we can set the Reg key for the VM in powershell and run the git command as we did locally in our workflow, from our template doc here: https://github.com/CommunityToolkit/Labs-Windows/tree/main/template#long-paths @Arlodotexe maybe something to try quick and see what happens? Otherwise, we can try and sort out later when we sync with the Uno folks in August. |
In addition to the Git command, it looks like there's a PowerShell command for this too. We should be able to use a similar command to read the value and see if it's enabled already. Set-ItemProperty 'HKLM:\System\CurrentControlSet\Control\FileSystem' -Name 'LongPathsEnabled' -value 1There's 2 considerations to hash out still:
Update: Will open a separate issue for this and continue discussion there. |
|
Before we can merge this, we need to manually add in changes done for #226 |
… latest multi-targetting changes.
Remove extra blank entry for empty text after last sample Fix template text for Markdown display
michael-hawker
force-pushed
the
llama/port-notifications
branch
from
137df39 to
572ba36
Compare
Should enable seeing results in GitHub commit check list
michael-hawker
force-pushed
the
llama/port-notifications
branch
from
572ba36 to
4205f6e
Compare
|
Well at least we're getting another error now? (And it worked on the WinUI 3 build!) Seems .NET Native related now: Going to try the fix suggested here and see what happens: https://dev.to/mhmd_azeez/solving-nutcdriver-exe-returned-code-1-error-while-building-uwp-app-in-release-mode-2mc6 - Related: dotnet/corert#5604 (And the test space changes seem to work, think there may be more we can do hear in the future, but them being connected in the GitHub commit check is the first step.) |
20 tasks
20 tasks
3 tasks
22 tasks
Arlodotexe
pushed a commit
that referenced
this pull request
Nov 16, 2022
Arlodotexe
added a commit
that referenced
this pull request
Nov 16, 2022
This reverts commit 92ecbc4.
michael-hawker
commented
Nov 17, 2022
2 tasks
|
@Arlodotexe think we discovered something. Reran the failed job, but appears that there's something in the test projects (maybe related to XML) that's tripping up the .NET Native compiler more consistently? When we abstracted running the tests from the .NET Native compiler, then things were fine. Maybe we do go back and not run tests through .NET Native, and add smoke tests later that use .NET Native...? 🤔 FYI @tommcdon, have you heard or aware of any of these issues with MSTest and .NET Native? |
|
This branch is now on par with I've added details in CommunityToolkit/Tooling-Windows-Submodule#9, let's continue the discussion there |
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…ort-notifications 🧪 Bring over StackedNotificationsBehavior from Toolkit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing from Toolkit
See Details in #210
Been using as my test/demo for presentation, so been working alright. Want to get initial version in.
Made some additional small tweaks: