Sample App Issue/Discussion Links and Markdown Rendering #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michael-hawker I'm still having some WASM issues on my local machine so haven't tested that yet. UWP looked good though! Removed some more obsolete links on the CanvasLayout and CanvasView page. |
niels9001
reviewed
Nov 9, 2022
common/CommunityToolkit.Labs.Shared/Renderers/Markdown/MarkdownTextBlock.cs
Show resolved
Hide resolved
michael-hawker
commented
Nov 9, 2022
common/CommunityToolkit.Labs.Shared/Renderers/Markdown/MarkdownTextBlock.cs
Outdated
Show resolved
Hide resolved
michael-hawker
force-pushed
the
llama/sample-app-links
branch
from
5c65fcc to
e81ebaa
Compare
michael-hawker
commented
Nov 10, 2022
common/CommunityToolkit.Labs.Shared/Renderers/Markdown/MarkdownTextBlock.cs
Show resolved
Hide resolved
michael-hawker
commented
Nov 10, 2022
platforms/CommunityToolkit.Labs.Wasm/CommunityToolkit.Labs.Wasm.csproj
Outdated
Show resolved
Hide resolved
michael-hawker
force-pushed
the
llama/sample-app-links
branch
from
e81ebaa to
5b1923c
Compare
|
Looks like we can get #211 in, so we'll merge that and then I'll update this PR on top of it. |
michael-hawker
force-pushed
the
llama/sample-app-links
branch
from
b87ad83 to
5db0ca1
Compare
|
@Arlodotexe I've updated this and tested locally on UWP, WASDK, and WASM. Working great there. Weird build issues with other platform heads trying to build the Let's see what happens in the CI. If it's clean, we should merge to get the improvements here. And then file a separate issue to figure out what's going on with VS? |
|
@niels9001 icons looks great now on WASM!
|
Arlodotexe
requested changes
Nov 29, 2022
| @@ -29,6 +29,12 @@ public partial class ToolkitSampleMetadataGenerator | |||
| private const string FrontMatterRegexSubcategoryExpression = @"^subcategory:\s*(?<subcategory>.*)$"; | |||
| private static readonly Regex FrontMatterRegexSubcategory = new Regex(FrontMatterRegexSubcategoryExpression, RegexOptions.Compiled | RegexOptions.IgnoreCase | RegexOptions.Multiline); | |||
|
|
|||
| private const string FrontMatterRegexDiscussionIdExpression = @"^labs-discussion:\s*(?<discussionId>.*)$"; | |||
There was a problem hiding this comment.
Let's remove "labs" from these two new fields. This source generator will serve both Labs and the main Toolkit.
common/CommunityToolkit.Labs.Shared/Renderers/ToolkitDocumentationRenderer.xaml.cs
Show resolved
Hide resolved
Arlodotexe
requested changes
Nov 29, 2022
Adds tests for validation with the Source Generator Updates Sample Documentation and View code buttons with links to the Discussion and Tracking Issue (not shown if not provided) Updates template and existing sample documentation with id numbers (zero (0) if no issue/discussion exists)
Centralizes Fonts.css file used in all WASM heads.
…/issue-id instead
michael-hawker
force-pushed
the
llama/sample-app-links
branch
from
5db0ca1 to
d9a813d
Compare
Arlodotexe
approved these changes
Dec 2, 2022
common/CommunityToolkit.Labs.Shared/Renderers/ToolkitDocumentationRenderer.xaml.cs
Show resolved
Hide resolved
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…ample-app-links Sample App Issue/Discussion Links and Markdown Rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
Tested in WASM locally
Known issues for Markdown