Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add processor template documentation #165

Merged
merged 9 commits into from
Nov 14, 2024
Merged

Conversation

AdamHaffar
Copy link
Contributor

Follows a similar style documentation to the Conduit Connector Template

@AdamHaffar AdamHaffar requested a review from a team as a code owner October 16, 2024 15:51
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024

Deploying conduit-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 105aec2
Status: ✅  Deploy successful!
Preview URL: https://236c9219.conduit-site.pages.dev
Branch Preview URL: https://adam-processor-template.conduit-site.pages.dev

View logs

@AdamHaffar
Copy link
Contributor Author

@lovromazgon, I have not included this line in the .mdx file, I am not sure what it does and if it is needed.

Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start 👍

docs/processors/standalone/conduit-processor-template.mdx Outdated Show resolved Hide resolved
docs/processors/standalone/conduit-processor-template.mdx Outdated Show resolved Hide resolved
@raulb
Copy link
Member

raulb commented Oct 24, 2024

@AdamHaffar Opened this other PR trying to help you out with some things I noticed on this pull-request. I figured it'd be easier to do that rather than posting a big comment. Let me know if something's not clear #179.

@raulb
Copy link
Member

raulb commented Nov 12, 2024

@AdamHaffar need help with anything? Would like to make progress on this, so please let us know if you're still considering working on that. Otherwise, I'll take over. Thank you

@AdamHaffar AdamHaffar enabled auto-merge (squash) November 12, 2024 23:26
@AdamHaffar AdamHaffar requested a review from raulb November 13, 2024 14:33
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AdamHaffar . Only one typo and should be good to go.

@AdamHaffar AdamHaffar merged commit 941f412 into main Nov 14, 2024
1 check passed
@AdamHaffar AdamHaffar deleted the adam/processor_template branch November 14, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants