Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for processor template documentation #179

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Oct 24, 2024

Hi @AdamHaffar, here are some fixes for #165.

Fixes

  • By having "conduit-processor-[processor name]," the MDX format was broken; hence, it wasn't being built correctly. It was expecting the URL for this (theoretically) markdown link.
  • Moves the page to its correct section after the recent documentation refactor (we have sections for using, developing, etc., with the appropriate one being Developing).
  • Removes the sidebar_position as a way to maintain the order. By using indexes, while being autogenerated, this order can be easily kept that way. More info here and here.
  • Fixes other links to newer docs.

@raulb raulb requested a review from a team as a code owner October 24, 2024 10:58
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2024

Deploying conduit-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 77c7e04
Status: ✅  Deploy successful!
Preview URL: https://236d192b.conduit-site.pages.dev
Branch Preview URL: https://adam-processor-template-fixe.conduit-site.pages.dev

View logs

@raulb raulb self-assigned this Oct 24, 2024
@raulb raulb requested a review from AdamHaffar October 24, 2024 11:02
@hariso hariso changed the title fixes #165 fixes for processor template documentation Oct 24, 2024
@lovromazgon lovromazgon merged commit 1621f0a into adam/processor_template Oct 28, 2024
1 check passed
@lovromazgon lovromazgon deleted the adam/processor_template-fixes branch October 28, 2024 17:47
AdamHaffar added a commit that referenced this pull request Nov 14, 2024
* add processor template documentation

* remove duplicate heading

Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>

* terminology consistency

* remove .mdx from links

* fixes for processor template documentation (#179)

* fixes

* fix links

---------

Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants