Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#33): fix Unhandled exception on null object error in transaction #3

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Jul 28, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

  • remove duplicate function renderLedgerSignButton
  • update latest renderLedgerSignButton function param for createStyles

Issue

https://app.zenhub.com/workspaces/cet-metamask-mobile-ledger-integration-649aeabc8cdfe3878d13629f/issues/zh/33

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

…nsaction

- remove duplicate function renderLedgerSignButton
- update latest renderLedgerSignButton function param for createStyles
@github-actions
Copy link

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

0 out of 1 committers have signed the CLA.
@stanleyyconsensys

@stanleyyconsensys stanleyyconsensys merged commit db707da into feat/ledger-integration Jul 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants