Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Competitive analysis: Onboarding #33

Closed
bdresser opened this issue Aug 9, 2018 · 1 comment
Closed

Competitive analysis: Onboarding #33

bdresser opened this issue Aug 9, 2018 · 1 comment

Comments

@bdresser
Copy link
Contributor

bdresser commented Aug 9, 2018

mobile-onboarding-imtoken
mobile-onboarding-toshi
mobile-onboarding-trust
mobile-onboardings
@bdresser
Copy link
Contributor Author

moved to mural: https://app.mural.co/t/consensys3989/m/consensys3989/1533837956196/e12ca150c3110ed189f7eae88198c1ea238607aa

sethkfman pushed a commit that referenced this issue Sep 3, 2021
@rekmarks
Colocate tests, update tsconfig.json (#33)
b0cc8e9
stanleyyconsensys added a commit to Consensys/metamask-mobile-fork that referenced this issue Jul 28, 2023
@stanleyyconsensys
fix(MetaMask#33): fix Unhandled exception on null object error in tra…
c52ab76 
…nsaction

- remove duplicate function renderLedgerSignButton
- update latest renderLedgerSignButton function param for createStyles
stanleyyconsensys added a commit to Consensys/metamask-mobile-fork that referenced this issue Jul 31, 2023
@stanleyyconsensys
Merge pull request #3 from Consensys/fix/unhandled-exception-on-null-…
db707da 
…object-error-

fix(MetaMask#33): fix Unhandled exception on null object error in transaction
stanleyyconsensys added a commit that referenced this issue Aug 17, 2023
@stanleyyconsensys @mlallai
Feat/ledger integration (#7004)
16fc6d0 
* fix: change to display same error message with keystone

- use isHardwareAccount instead isQRHardwareAccount

* fix(#33): fix Unhandled exception on null object error in transaction

- remove duplicate function renderLedgerSignButton
- update latest renderLedgerSignButton function param for createStyles

* fix(#34): incorrect label when using browser

- fix action view default label , defaultProps is not able to translate

* fix(#24): fix uncatch error on unsigned transaction in ledger

- signLedgerTransaction is not being pass when using TransactionElement

* fix: remove label on transaction screen for MM accounts

* fix(#44): fix legacy code

- replace AppState.removeEventListener to remove
- replace TransactionController.cancelTransaction to ApprovalController.reject

* fix(#44): replace legacy approval transaction

- fix duplicate language block in en.json
- replace legacy approval transaction

* fix: ledger label on wallet screen

* fix(#44): remove legacy conflict code in transaction sending flow

---------

Co-authored-by: mlallai <matthieu.lallai@gmail.com>
Co-authored-by: stanleyyconsensys <stanley.yuen@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdresser