Feat/ledger integration #7004
Merged
Feat/ledger integration #7004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use isHardwareAccount instead isQRHardwareAccount
…nsaction - remove duplicate function renderLedgerSignButton - update latest renderLedgerSignButton function param for createStyles
- fix action view default label , defaultProps is not able to translate
- signLedgerTransaction is not being pass when using TransactionElement
…saction-in-ledger fix(MetaMask#24): uncaught error unsigned transaction in ledger
…g-transaction-via-browser fix(MetaMask#34): incorrect label when signing transaction via browser
…object-error- fix(MetaMask#33): fix Unhandled exception on null object error in transaction
…-user-tries-to-reveal-Ledger-private-key fix(MetaMask#18): change to display same error message with keystone
- replace AppState.removeEventListener to remove - replace TransactionController.cancelTransaction to ApprovalController.reject
- fix duplicate language block in en.json - replace legacy approval transaction
fix (MetaMask#17): Unknown labels on transaction screen for MetaMask and imported accounts
fix: ledger label on wallet screen
…e-conflict-on-approval fix (MetaMask#44): fix legacy code with merge conflict on approval
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sync latest ledger integration code from fork
Checklist