Patch release 0.7.3 branch back to master #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a network is created by discovery over configuration.
Add start acceptance tests to ensure that empty key values are validated and startup is supressed.
debug level the message and status is returned to the client.
This reverts commit dfe7845.
…n vaultId is invalid - not the whole filepath. This test case used an invalid filepath - which might or might not result in InvalidPathException depending on the default filesystem encoding.
Address issues found in 0.7 release
Conflicts: argon2/pom.xml config-cli/pom.xml config-migration/pom.xml config/pom.xml data-migration/pom.xml encryption/encryption-api/pom.xml encryption/encryption-jnacl/pom.xml encryption/encryption-kalium/pom.xml encryption/pom.xml grpc-api/pom.xml grpc-service/pom.xml grpc/pom.xml jaxrs-client/pom.xml jaxrs-service/pom.xml key-generation/pom.xml key-vault/azure-key-vault/pom.xml key-vault/key-vault-api/pom.xml key-vault/pom.xml pom.xml security/pom.xml server/grpc-server/pom.xml server/jersey-server/pom.xml server/pom.xml server/resteasy-server/pom.xml server/server-api/pom.xml server/unix-socket-server/pom.xml service-locator/pom.xml service-locator/service-locator-api/pom.xml service-locator/service-locator-spring/pom.xml shared/pom.xml tessera-app/pom.xml tessera-core/pom.xml tests/acceptance-test/pom.xml tests/pom.xml tests/test-util/pom.xml
melowe
requested review from
chris-j-h,
namtruong and
nicolae-leonte-go
as code owners
This was referenced Nov 16, 2018
Closed
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
============================================
+ Coverage 99.41% 99.42% +<.01%
- Complexity 1234 1257 +23
============================================
Files 209 211 +2
Lines 3935 3975 +40
Branches 210 212 +2
============================================
+ Hits 3912 3952 +40
Misses 5 5
Partials 18 18
Continue to review full report at Codecov.
|
|
|
||
| final byte[] urlBytes = new byte[urlLength]; | ||
| byteBuffer.get(urlBytes); | ||
| final String url = new String(urlBytes, UTF_8); | ||
|
|
||
| final int numberOfRecipients = (int) byteBuffer.getLong(); | ||
| final int numberOfRecipients = (int) toIntExact(byteBuffer.getLong()); | ||
| checkLength(urlLength); |
There was a problem hiding this comment.
Should this be checkLength(numberOfRecipients); ?
There was a problem hiding this comment.
Well spotted Nicolae!
Bugfix partyinfo line46
melowe
changed the title
breaking docket build.
Not sure what this is doing here. Remove unwanted directory that's
unwanted submodule.
unwanted submodule.
melowe
changed the title
prd-fox
approved these changes
Nov 19, 2018
namtruong
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.