Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off buggy WASM metrics #637

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Conversation

wojtek-coreum
Copy link
Collaborator

@wojtek-coreum wojtek-coreum commented Sep 6, 2023

Description

Due to buggy initialization of metrics collector, WASM causes panics when metrics are collected.
Bug is described here: CosmWasm/wasmd#1574
and fixed here: CosmWasm/wasmd#1575

Once v0.42 is released we may uncomment this code. Task has been created for this.

Reviewers checklist:

  • Try to write more meaningful comments with clear actions to be taken.
  • Nit-picking should be unblocking. Focus on core issues.

Authors checklist

  • Provide a concise and meaningful description
  • Review the code yourself first, before making the PR.
  • Annotate your PR in places that require explanation.
  • Think and try to split the PR to smaller PR if it is big.

This change is Reviewable

@wojtek-coreum wojtek-coreum requested a review from a team as a code owner September 6, 2023 08:45
@wojtek-coreum wojtek-coreum requested review from dzmitryhil, vertex451, miladz68 and ysv and removed request for a team September 6, 2023 08:45
miladz68
miladz68 previously approved these changes Sep 6, 2023
Copy link
Contributor

@miladz68 miladz68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dzmitryhil, @vertex451, and @ysv)

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @vertex451, @wojtek-coreum, and @ysv)


app/app.go line 567 at r2 (raw file):

	// FIXME (wasmd-1575): This is commented out temporarily because it causes panics in telemetry server due to buggy
	// initialization of wasm vm in version v0.41 of wasmd.

But if it's fixed probably it's better to update the dependency?

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @vertex451, @wojtek-coreum, and @ysv)

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dzmitryhil, @vertex451, and @ysv)


app/app.go line 567 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

But if it's fixed probably it's better to update the dependency?

To the latest commit in master? But I'm not sure they follow the same very useful policy that every commit in master should work. That's why I prefer to wait until new official release.

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vertex451 and @ysv)


app/app.go line 567 at r2 (raw file):

Previously, wojtek-coreum (Wojtek) wrote…

To the latest commit in master? But I'm not sure they follow the same very useful policy that every commit in master should work. That's why I prefer to wait until new official release.

Ok, agree. Do we have a corresponding task to enable it back?

Copy link
Contributor

@ysv ysv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vertex451)

Copy link
Collaborator Author

@wojtek-coreum wojtek-coreum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vertex451)


app/app.go line 567 at r2 (raw file):

Previously, dzmitryhil (Dzmitry Hil) wrote…

Ok, agree. Do we have a corresponding task to enable it back?

yes

Copy link
Contributor

@dzmitryhil dzmitryhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @vertex451)

@wojtek-coreum wojtek-coreum merged commit 00d4a8d into master Sep 7, 2023
8 checks passed
@wojtek-coreum wojtek-coreum deleted the wojtek/turn-off-wasm-metrics branch September 7, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants