fix: make sure wasmvm cache metrics collector registration after VM setup #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1575 +/- ##
==========================================
+ Coverage 58.00% 58.03% +0.02%
==========================================
Files 64 64
Lines 8640 8640
==========================================
+ Hits 5012 5014 +2
+ Misses 3215 3214 -1
+ Partials 413 412 -1
|
alpe
approved these changes
Aug 28, 2023
6 tasks
wojtek-coreum
added a commit
to CoreumFoundation/coreum
that referenced
this pull request
Sep 7, 2023
# Description Due to buggy initialization of metrics collector, WASM causes panics when metrics are collected. Bug is described here: CosmWasm/wasmd#1574 and fixed here: CosmWasm/wasmd#1575 Once v0.42 is released we may uncomment this code. Task has been created for this. # Reviewers checklist: - [ ] Try to write more meaningful comments with clear actions to be taken. - [ ] Nit-picking should be unblocking. Focus on core issues. # Authors checklist - [x] Provide a concise and meaningful description - [x] Review the code yourself first, before making the PR. - [x] Annotate your PR in places that require explanation. - [x] Think and try to split the PR to smaller PR if it is big.
braverdever
added a commit
to braverdever/Coreum
that referenced
this pull request
Oct 24, 2023
# Description Due to buggy initialization of metrics collector, WASM causes panics when metrics are collected. Bug is described here: CosmWasm/wasmd#1574 and fixed here: CosmWasm/wasmd#1575 Once v0.42 is released we may uncomment this code. Task has been created for this. # Reviewers checklist: - [ ] Try to write more meaningful comments with clear actions to be taken. - [ ] Nit-picking should be unblocking. Focus on core issues. # Authors checklist - [x] Provide a concise and meaningful description - [x] Review the code yourself first, before making the PR. - [x] Annotate your PR in places that require explanation. - [x] Think and try to split the PR to smaller PR if it is big.
braverdever
pushed a commit
to swordEdge/Coreum
that referenced
this pull request
Oct 24, 2023
# Description Due to buggy initialization of metrics collector, WASM causes panics when metrics are collected. Bug is described here: CosmWasm/wasmd#1574 and fixed here: CosmWasm/wasmd#1575 Once v0.42 is released we may uncomment this code. Task has been created for this. # Reviewers checklist: - [ ] Try to write more meaningful comments with clear actions to be taken. - [ ] Nit-picking should be unblocking. Focus on core issues. # Authors checklist - [x] Provide a concise and meaningful description - [x] Review the code yourself first, before making the PR. - [x] Annotate your PR in places that require explanation. - [x] Think and try to split the PR to smaller PR if it is big.
Superdev1010
added a commit
to Superdev1010/Coreum
that referenced
this pull request
Mar 4, 2024
# Description Due to buggy initialization of metrics collector, WASM causes panics when metrics are collected. Bug is described here: CosmWasm/wasmd#1574 and fixed here: CosmWasm/wasmd#1575 Once v0.42 is released we may uncomment this code. Task has been created for this. # Reviewers checklist: - [ ] Try to write more meaningful comments with clear actions to be taken. - [ ] Nit-picking should be unblocking. Focus on core issues. # Authors checklist - [x] Provide a concise and meaningful description - [x] Review the code yourself first, before making the PR. - [x] Annotate your PR in places that require explanation. - [x] Think and try to split the PR to smaller PR if it is big.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #1574
This PR intends to fix the bug mentioned by #1574, to make sure wasmvm cache metrics collector registration after VM setup.