-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump dependency versions #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add those Wasm build check to the CI? This will prevent such problems in the future: https://github.com/CosmWasm/cw-storage-plus/pull/23/files
@webmaster128 Removed anyhow and serde_json, updated CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there are breaking change in the prost cw2 or cw-storage-plus upgrades that affect this create. I'm not familiar with the codebase. The rest LGTM.
Turned on "Build forked pull requests" now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just suggestions, since it's the same.
# Once we bump `cosmwasm-*` deps to a version after `1.1.5`, we can remove these. | ||
serde_json = "1.0.40" | ||
cw-storage-plus = "1.0.1" | ||
prost = "0.11.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prost = "0.11.0" | |
prost = "0.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem with those changes it it makes the patch release invisible. This is often the cause for setting the min version of a dependency too low. If there is .0
you see that you either want .0 or that you want something else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it doesn't make them invisible - it literally means the same. I would go even further, some users who don't understand how Cargo dep versioning works might be confused.
I'm good either way. 👍
cw2 = "0.16" | ||
cosmwasm-schema = "1.1.9" | ||
cosmwasm-std = "1.1.9" | ||
cw2 = "1.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cw2 = "1.0.0" | |
cw2 = "1.0" |
Closes: #3
Including
k256
as a dependency leads to a compilation error:This PR removes
k256
and bump all dependencies to latest.