Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependency versions #4

Merged
merged 5 commits into from
Dec 12, 2022
Merged

bump dependency versions #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
172a229
bump dependency versions
larry0x Dec 7, 2022
d8e053c
remove unused dependencies
larry0x Dec 7, 2022
68c01eb
update CI
larry0x Dec 7, 2022
ffb1b52
Move wasm builds to build_and_test job
webmaster128 Dec 12, 2022
cf91948
Bum min anyhow version
webmaster128 Dec 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ jobs:
- run:
name: Version information
command: rustc --version; cargo --version; rustup --version; rustup target list --installed
- run:
name: Add wasm32 target
command: rustup target add wasm32-unknown-unknown && rustup target list --installed
- run:
name: Generate a lockfile
command: cargo update
Expand All @@ -47,6 +50,12 @@ jobs:
- run:
name: Build library for native target
command: cargo build --locked
- run:
name: Build library for Wasm target (default features)
command: cargo build --target wasm32-unknown-unknown --locked
- run:
name: Build library for Wasm target (all features)
command: cargo build --target wasm32-unknown-unknown --locked --all-features
- run:
name: Run unit tests
command: cargo test --locked
Expand Down
49 changes: 29 additions & 20 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 6 additions & 16 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,15 @@ homepage = "https://cosmwasm.com"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
cosmwasm-schema = "1.0.0"
cosmwasm-std = "1.0.0"
cw2 = "0.16"
cosmwasm-schema = "1.1.9"
cosmwasm-std = "1.1.9"
cw2 = "1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cw2 = "1.0.0"
cw2 = "1.0"

schemars = "0.8.1"
semver = "1"
serde = { version = "1.0.0", default-features = false, features = ["derive"] }
thiserror = "1.0.13"

# We don't use the following dependencies directly. They're dependencies of our dependencies.
# We specify them to tighten their version requirements so that builds with `-Zminimal-versions` work.
# Once we bump `cosmwasm-*` deps to a version after `1.1.5`, we can remove these.
k256 = { version = "0.11.1", features = ["ecdsa"] }
anyhow = "1.0.41"

[dev-dependencies]
cw-storage-plus = "0.16"
prost = "0.9"

# We don't use the following dependencies directly. They're dependencies of our dependencies.
# We specify them to tighten their version requirements so that builds with `-Zminimal-versions` work.
# Once we bump `cosmwasm-*` deps to a version after `1.1.5`, we can remove these.
serde_json = "1.0.40"
cw-storage-plus = "1.0.1"
prost = "0.11.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
prost = "0.11.0"
prost = "0.11"

Copy link
Member

@webmaster128 webmaster128 Dec 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with those changes it it makes the patch release invisible. This is often the cause for setting the min version of a dependency too low. If there is .0 you see that you either want .0 or that you want something else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it doesn't make them invisible - it literally means the same. I would go even further, some users who don't understand how Cargo dep versioning works might be confused.
I'm good either way. 👍

anyhow = "1.0.65" # Not used directly but prost-derive does not set a sufficiently high anyhow version