Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second 47 #1080

Closed
wants to merge 62 commits into from
Closed

second 47 #1080

wants to merge 62 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Nov 8, 2022

Wasmd with sdk 47 and ibcv6

@faddat faddat requested a review from alpe as a code owner November 8, 2022 00:47
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2022

⚠️ The sha of the head commit of this PR conflicts with #938. Mergify cannot evaluate rules on this PR. ⚠️

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1080 (b385d2d) into main (7243617) will decrease coverage by 0.54%.
The diff coverage is 42.78%.

❗ Current head b385d2d differs from pull request most recent head 45ee197. Consider uploading reports for the commit 45ee197 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1080      +/-   ##
==========================================
- Coverage   59.31%   58.76%   -0.55%     
==========================================
  Files          53       53              
  Lines        6722     6778      +56     
==========================================
- Hits         3987     3983       -4     
- Misses       2441     2499      +58     
- Partials      294      296       +2     
Impacted Files Coverage Δ
app/export.go 11.53% <0.00%> (-0.59%) ⬇️
app/test_access.go 0.00% <ø> (ø)
app/test_helpers.go 0.73% <0.00%> (-0.06%) ⬇️
x/wasm/client/cli/gov_tx.go 6.26% <0.00%> (-0.27%) ⬇️
x/wasm/keeper/handler_plugin.go 85.14% <ø> (ø)
x/wasm/keeper/ibc.go 77.77% <ø> (ø)
x/wasm/keeper/proposal_handler.go 60.00% <ø> (-8.00%) ⬇️
x/wasm/keeper/query_plugins.go 81.10% <ø> (ø)
x/wasm/keeper/snapshotter.go 62.85% <0.00%> (-1.85%) ⬇️
x/wasm/module.go 38.52% <ø> (+0.62%) ⬆️
... and 13 more

@alpe alpe added the spike Demo to showcase an idea. label Nov 8, 2022
@alpe
Copy link
Contributor

alpe commented Nov 8, 2022

Thanks for your new spike! 🏄 I will follow up on the sdk 0.47 work as soon as the v0.30. release is tagged.
It would be easier if you keep SDK and IBC upgrades in separate PRs.

github.com/cosmos/cosmos-proto v1.0.0-alpha7
github.com/cosmos/cosmos-sdk v0.45.9
github.com/cosmos/cosmos-proto v1.0.0-alpha8
github.com/cosmos/cosmos-sdk v0.46.0-beta2.0.20221107225151-b49f948b36bc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is main branch, right?

We definitely want to get a proper CI and testing on this once this is tagged (as an rc) along with ibc-go.
Thanks for having an eye on it... I hear some rc tags are coming soon....

@faddat
Copy link
Contributor Author

faddat commented Nov 14, 2022

Hey guys, I will likely recreate this PR again, with help from our Juno team. I will also fill in the steps as I see them on #1022

@faddat faddat closed this Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike Demo to showcase an idea.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants