Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmd v0.29.2 and SDK v0.46.6 and IBC v5.1.0 #938

Closed
wants to merge 70 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 13, 2022

Funded by Juno, built by Notional

wasmd for the SDK 46 series:

  • ibc-go v5.2.0
  • tendermint v0.34.24
  • cosmos sdk v0.46.6
  • interchain-accounts v0.32.1+dragonberry patch
  • iavl v0.19.4
  • wasmd v0.29.2

NOTICE

Some somewhat conflicting information about the status of cosmos-sdk v0.46.* was released on the cosmos hub forum, here:

https://forum.cosmos.network/t/ibc-security-advisory-dragonberry/7702

Later discussions with the SDK team and Umee revealed that a patch was underway. Notional will continue to maintain this branch so that users of sdk 46 are able to work with security.

Given that this branch has active users that want to make chain happen, we're going to try to restore it to its former glory, specifically, it should pass 100% of the tests.

I am iffy on all of this, but it ought to be 1-3 days work to ensure that this branch works again. When it passes all tests, I will remove the below warning. Notional will continue to work on SDK v47 support for:

  • ibc-go
  • interchain-accounts-demo
  • wasmd

Guidance

THis commit hash b385d2d

corresponds to the last known fully good happy version, and it also corresponds to v0.29.1 in main.

Funded by Juno built by Notional

@faddat faddat requested a review from alpe as a code owner August 13, 2022 15:56
@faddat faddat marked this pull request as draft August 15, 2022 09:47
@faddat
Copy link
Contributor Author

faddat commented Aug 15, 2022

@vuong177 🔥

@faddat
Copy link
Contributor Author

faddat commented Aug 15, 2022

@vuong177 I think you've hit an ibc-go bug. If you look at ibc-go v3.2.0, you'll see a commit from @joeabbey.

His most recent commit fixes something something sequence numbers, and by doing that, also fixes the reflect test.

hm, I thought of something else that may solve....

@faddat
Copy link
Contributor Author

faddat commented Aug 15, 2022

@vuong177 I checked, and the commit that we're using here, is up to date with the latest commit from ibc-go, so it might not be that....

@vuong177
Copy link
Contributor

yep, seem have problem with router

@faddat
Copy link
Contributor Author

faddat commented Aug 16, 2022

Great progress!

@faddat
Copy link
Contributor Author

faddat commented Nov 7, 2022

THis commit hash b385d2d

corresponds to the last known fully good happy version, and it also corresponds to v0.29.1

@mergify mergify bot mentioned this pull request Nov 8, 2022
ravaliGangasani and others added 4 commits November 8, 2022 13:08
adding instantiate-anyof-addresses flag in the gov_tx.go

(cherry picked from commit b7e4770)
@faddat
Copy link
Contributor Author

faddat commented Nov 8, 2022

NB: this is v0.29.2 + needed adaptations for 46

this commit:
0abadd1

is working nicely.

This patch may require this:

https://twitter.com/gadikian/status/1592157214600749057

cosmos/interchain-accounts-demo#152

or be subject to occasional bech32 wierdnesses.

@faddat faddat changed the title SDK v0.46.3 and IBC v5 SDK v0.46.4 and IBC v5 Nov 14, 2022
@faddat faddat changed the title SDK v0.46.4 and IBC v5 SDK v0.46.4 and IBC v5.1.0 Nov 14, 2022
@faddat faddat changed the title SDK v0.46.4 and IBC v5.1.0 SDK v0.46.6 and IBC v5.1.0 Nov 19, 2022
@MSNTCS
Copy link

MSNTCS commented Nov 21, 2022

@faddat nice job. is there any timeline for merging this?

@faddat
Copy link
Contributor Author

faddat commented Dec 3, 2022

Hey, @MSNTCS I think that the wasmd team will be merging work based on sdk v0.47.*, not this.

I must also mention this:

cosmos/cosmos-sdk#14103

This branch has really been a moving target.

I think the above change will require updates to ibc-go also.

@faddat faddat mentioned this pull request Dec 8, 2022
9 tasks
@faddat
Copy link
Contributor Author

faddat commented Dec 8, 2022

Important Notes on SDK v0.47.x work and information on how we see items like this branch:

@faddat faddat changed the title SDK v0.46.6 and IBC v5.1.0 wasmd v0.29.2 and SDK v0.46.6 and IBC v5.1.0 Dec 13, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 40 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alpe
Copy link
Member

alpe commented Jan 9, 2023

You have 2 branches open for SDK v0.46. Can this be closed in favour of #1126? Or the other way?

@faddat
Copy link
Contributor Author

faddat commented Jan 28, 2023

Yeah, I think that makes sense. No one building, should make a chain with this one. Thanks!

@faddat faddat closed this Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike Demo to showcase an idea.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants