fix: stargate querier does not reset the structure state

[dadamu]

Currently, the stargate querier marshal the result to the given structure stored in accepted list, but it does not reset the state. So the result will be unexpected. For example, the current stargate querier process is like:

cdc, _ := app.MakeCodecs()

protoResponse := &banktypes.QueryAllBalancesResponse{}

bz, err := cdc.Marshal(&banktypes.QueryAllBalancesResponse{
Balances: sdk.NewCoins(sdk.NewInt64Coin("test", 1)),
})

// First stargate query to QueryAllBalances 
err = cdc.Unmarshal(bz, protoResponse)
if err != nil {
panic(err)
}

// Second stargate query to QueryAllBalances 
err = cdc.Unmarshal(bz, protoResponse)
if err != nil {
panic(err)
}

fmt.Println(protoResponse.String())
// balances:<denom:"test" amount:"1" > balances:<denom:"test" amount:"1" >
// but the expected result is: balances:<denom:"test" amount:"1" >>

As a result, we should reset the protoResponse after marshaling.

[codecov]

Codecov Report

Merging #1208 (6d8018a) into main (88e01a9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1208   +/-   ##
=======================================
  Coverage   57.49%   57.50%           
=======================================
  Files          54       54           
  Lines        7435     7436    +1     
=======================================
+ Hits         4275     4276    +1     
  Misses       2861     2861           
  Partials      299      299           

Impacted Files	Coverage Δ
x/wasm/keeper/query_plugins.go	82.60% <100.00%> (+0.05%)	⬆️

[alpe]

Thanks for the PR and this important fix! I hope that we can resume OS work very soon. Please see #1198 for context

[alpe]

Would you mind to convert your description into a unit test for regression so that we also have confidence in the future?

[dadamu]

@alpe Added.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[faddat]

Thanks!

[alpe]

Great work! Thanks a lot for adding the test, too. Important work!🥇