Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

47 with token factory #1209

Closed
wants to merge 74 commits into from
Closed

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Feb 24, 2023

  • attempts to ensure that all v0.31.x changes are present (I am not 100% sure of this)
  • uses cometbft in all places
  • uses ibc-go v7.1.x w/ wasm clients
  • uses cosmos-sdk v0.47.x
  • includes the token factory as a first class citizen

...if .... the awesome rumors I heard about x/wasm joining the cosmos-sdk are true, I think this could make a great final release.

If those awesome rumors aren't true, please let me know if it is possible to help to make those rumors true.

<3

-Jacob

This PR contains:

alpe and others added 30 commits January 11, 2023 11:10
* Upgrade to sdk v0.47 branch

* More integration work

* SDK version upgrade; fixes

* More fixes

* Fixes

* Deactivate failing tests

* SDK + ibc-go version upgrades

* limix gas fix

(cherry picked from commit f7f8417)

* with valset in bench

(cherry picked from commit 35b2a8f)

* Revert staking query handler; fix tests

* Minor cleanup

* Rebased

* Address linter issues

* Set legacy router proper

* Deactivate failing test. Race condition needs to handled in SDK

* Address some code smells

* Bump sdk version

* Use gov v1 internally for votes

* Activate test after sdk fix

* Add group test

* Add config template for wasm fields

* Add Rust backtrace flag for more debug output on simulations

* Set unique node folder for tests

* Revert "Add Rust backtrace flag for more debug output on simulations"

This reverts commit 218c3c6.

* Simulations

* Run also im/export + deterministic sims

* Add package prefix to interfaces

* Add signer annotation (cosmos/cosmos-sdk#10933), minor cleanup

* Bump sdk version

* Review comments

Co-authored-by: vuong <nguyenvuong1122000@gmail.com>
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.11.0 to 1.12.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.11.0...v1.12.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit f490595)
…47/pr-1151

Bump bufbuild/buf-setup-action from 1.11.0 to 1.12.0 (backport CosmWasm#1151)
(cherry picked from commit 38d466a)
…47/pr-1167

Fix msg format in EVENTS.md (backport CosmWasm#1167)
* Better to sdk coin convertion

* Review feedback

(cherry picked from commit a925a9e)
…47/pr-1164

Better to sdk coin convertion (backport CosmWasm#1164)
* Remove AccessTypeOnlyAddress for store msg

* Remove AccessTypeOnlyAddress for update config msg

* Review feedback

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>

Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
(cherry picked from commit 8991633)
* Integrate wasmvm v1.2.0 (CosmWasm#1161)

* Bump wasmvm version

* Bump wasm test contracts

* Encode weighted votes

* Encode instantiate2

* Handle code info query; better wasmvm errors

* Fix readme

* Make linter happy

* add non cgo build

* Review comments

* Bump wasmvm to release version

Co-authored-by: jhernandezb <contact@jhernandez.me>
(cherry picked from commit 957b38e)

# Conflicts:
#	x/wasm/keeper/handler_plugin_encoders.go
#	x/wasm/keeper/handler_plugin_encoders_test.go
#	x/wasm/keeper/keeper.go
#	x/wasm/keeper/keeper_test.go

* Adress merge conflicts

Co-authored-by: Alexander Peters <alpe@users.noreply.github.com>
…47/pr-1163

Disallow only address permission (backport CosmWasm#1163)
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.12.0...v1.13.0)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit ffa0e5e)
…47/pr-1181

Bump bufbuild/buf-setup-action from 1.12.0 to 1.13.0 (backport CosmWasm#1181)
* Bump sdk version to lastest

* Bump ibc-go  version to lastest

* Remove channel hack
…47/pr-1179

Emit events for setContractAdmin + setAccessConfig (backport CosmWasm#1179)
Update to ibc-go v7 beta2 + protoVer=0.11.5
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.13.0 to 1.13.1.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases)
- [Commits](bufbuild/buf-setup-action@v1.13.0...v1.13.1)

---
updated-dependencies:
- dependency-name: bufbuild/buf-setup-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
(cherry picked from commit de27e7f)
…47/pr-1191

Bump bufbuild/buf-setup-action from 1.13.0 to 1.13.1 (backport CosmWasm#1191)
* Fix typos

(cherry picked from commit c88b819)

# Conflicts:
#	proto/cosmwasm/wasm/v1/tx.proto

* Fix merge conflict

---------

Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
@faddat faddat requested a review from alpe as a code owner February 24, 2023 23:36
// Setup sets up basic environment for suite (App, Ctx, and test accounts)
func (s *KeeperTestHelper) Setup() {
s.App = app.Setup(s.T())
s.Ctx = s.App.BaseApp.NewContext(false, tmtypes.Header{Height: 1, ChainID: "osmosis-1", Time: time.Now().UTC()})

Check warning

Code scanning / CodeQL

Calling the system time

Calling the system time may be a possible source of non-determinism
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 198 Code Smells

No Coverage information No Coverage information
18.0% 18.0% Duplication

@alpe
Copy link
Contributor

alpe commented Feb 28, 2023

Thanks Jakub!
Please keep PRs to the point and not use it for lobbying or rumours. I am closing this PR for this reason.

See also #911 about tokenfactory
Note: #1198

@alpe alpe closed this Feb 28, 2023
@faddat
Copy link
Contributor Author

faddat commented Mar 1, 2023

Dude this isn't lobbying or rumors! Nobody has any idea if or when this repository is going to be developed again. That is not my fault!

@faddat
Copy link
Contributor Author

faddat commented Mar 1, 2023

Ohhhh, you mean:

...if .... the awesome rumors I heard about x/wasm joining the cosmos-sdk are true, I think this could make a great final release.

Guess what?

That is what I heard. And I heard absolutely nothing from Confio. I will now make a rumor-free PR, but seriously, get a grip on yourselves. Confio created an information vacuum. There are endless rumors. That is Confio's fault. Don't blame the folks who just kept at the grind please.

Furthermore, as purveyors of public goods, why are we NOT having these conversations in public?

pish.

If we aren't conversing openly how are contributors supposed to know the roadmap?

@faddat
Copy link
Contributor Author

faddat commented Mar 1, 2023

I've fixed the code of conduct

@faddat faddat mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants