Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9.1 to cosmos sdk 0.39 #169

Closed
wants to merge 6 commits into from
Closed

0.9.1 to cosmos sdk 0.39 #169

wants to merge 6 commits into from

Conversation

alpe
Copy link
Member

@alpe alpe commented Jul 1, 2020

Rebased #146 on top of current master


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alpe alpe force-pushed the 0.9.1_to_cosmos-sdk-0.39 branch from 06d7db7 to c5438b4 Compare July 1, 2020 13:58
@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #169 into master will decrease coverage by 32.90%.
The diff coverage is 9.98%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #169       +/-   ##
===========================================
- Coverage   67.90%   34.99%   -32.91%     
===========================================
  Files          23       25        +2     
  Lines        2053     4089     +2036     
===========================================
+ Hits         1394     1431       +37     
- Misses        563     2562     +1999     
  Partials       96       96               
Impacted Files Coverage Δ
app/genesis.go 0.00% <0.00%> (ø)
x/wasm/internal/types/msg.go 40.77% <ø> (ø)
x/wasm/internal/types/types.go 31.81% <0.00%> (-0.59%) ⬇️
x/wasm/module.go 17.77% <0.00%> (ø)
x/wasm/internal/types/types.pb.go 0.54% <0.54%> (ø)
app/export.go 7.31% <60.00%> (ø)
x/wasm/handler.go 50.78% <75.86%> (+0.78%) ⬆️
lcd_test/helpers.go 74.45% <94.11%> (-0.55%) ⬇️
x/wasm/internal/keeper/test_common.go 83.18% <97.14%> (-0.99%) ⬇️
app/app.go 93.22% <98.03%> (+4.07%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f62e8a...c5438b4. Read the comment docs.

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Of course this is not to merge.

Can you take this branch and force-push over cosmos-sdk-0.39? Then #146 is up to date.

@ethanfrey
Copy link
Member

Don't worry about codecov for now... busy enough following 0.39-dev. Let's worry about getting it back up when 0.39 is tagged... otherwise we just have to keep porting more tests.

@ethanfrey
Copy link
Member

What's keeping us from updating #146 with this code? It looks better and up to date

@alpe
Copy link
Member Author

alpe commented Jul 3, 2020

Done. I was just busy with #172

@alpe alpe closed this Jul 3, 2020
@alpe alpe deleted the 0.9.1_to_cosmos-sdk-0.39 branch July 3, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants