Better genesis import #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
force-pushed
the
better_genesis_import
branch
from
2c00d4a
to
16f6a28
Compare
|
I just merged #195 Can you rebase this and I will gladly review |
alpe
force-pushed
the
better_genesis_import
branch
from
16f6a28
to
882d817
Compare
|
Rebased. Sorry, too many PRs... |
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 71.96% 71.88% -0.08%
==========================================
Files 27 27
Lines 2572 2604 +32
==========================================
+ Hits 1851 1872 +21
- Misses 611 622 +11
Partials 110 110
Continue to review full report at Codecov.
|
ethanfrey
approved these changes
Jul 20, 2020
| continue | ||
| } | ||
| bytecode, err := keeper.GetByteCode(ctx, i) | ||
| keeper.IterateCodeInfos(ctx, func(codeID uint64, info types.CodeInfo) bool { |
There was a problem hiding this comment.
Callbacks are good. We will need them to scale up
zemyblue
pushed a commit
to Finschia/wasmd
that referenced
this pull request
Jan 2, 2023
Remove install-debug target from Makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚧 After #195
This started as #144 when I realized that the work was done already.
Some additional improvements:
IterateCodeInfosto keeperListContractInfotoIterateContractInfoAnd some additional genesis import assertions.
Reviewer note:
Only the last 2 commits. The others are from #195
For admin use:
WIP,R4R,docs, etc)