Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Json validation #199

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Better Json validation #199

merged 1 commit into from
Jul 20, 2020

Conversation

alpe
Copy link
Member

@alpe alpe commented Jul 17, 2020

After #198

Fail fast on invalid json msg payload.


For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alpe alpe requested a review from ethanfrey as a code owner July 17, 2020 13:16
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (better_genesis_import@882d817). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             better_genesis_import     #199   +/-   ##
========================================================
  Coverage                         ?   71.87%           
========================================================
  Files                            ?       27           
  Lines                            ?     2610           
  Branches                         ?        0           
========================================================
  Hits                             ?     1876           
  Misses                           ?      624           
  Partials                         ?      110           
Impacted Files Coverage Δ
x/wasm/internal/types/msg.go 52.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882d817...1c4d4d8. Read the comment docs.

@alpe alpe marked this pull request as draft July 20, 2020 09:11
@alpe alpe marked this pull request as ready for review July 20, 2020 09:13
@alpe alpe mentioned this pull request Jul 20, 2020
3 tasks
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvements. I will review the base PR when the diff is clearer.

x/wasm/client/cli/query.go Show resolved Hide resolved
Base automatically changed from better_genesis_import to master July 20, 2020 14:42
@alpe alpe merged commit 5c5e0f2 into master Jul 20, 2020
@alpe alpe deleted the json_validation branch July 20, 2020 14:45
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
…#199)

* Bump github.com/tendermint/tendermint from 0.32.7 to 0.32.8

Bumps [github.com/tendermint/tendermint](https://github.com/tendermint/tendermint) from 0.32.7 to 0.32.8.
- [Release notes](https://github.com/tendermint/tendermint/releases)
- [Changelog](https://github.com/tendermint/tendermint/blob/master/CHANGELOG.md)
- [Commits](tendermint/tendermint@v0.32.7...v0.32.8)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Update go.{mod,sum}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants