Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK 045 #720

Closed
wants to merge 2 commits into from
Closed

SDK 045 #720

wants to merge 2 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jan 17, 2022

Hi, to the best of my knowledge, 045 has some gas changes that will be useful for cw, so I've gone ahead and bumped this to v0.45.0

@faddat faddat requested a review from alpe as a code owner January 17, 2022 07:38
@ethanfrey
Copy link
Member

Thanks for this PR.
It seems to fail with the new SetOrderMigrations assertion.
I am not sure what the suggested values for that are (I am sure there are some from simapp). It would be nice to see this pass CI.

@alpe
Copy link
Contributor

alpe commented Jan 17, 2022

@faddat thanks for the PR! There was a bit more work with app.go and some gas tests settings. I am closing this now in favour of #721

@alpe alpe closed this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alpe alpe Awaiting requested review from alpe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faddat @ethanfrey @alpe