Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to SDK v0.45.0-rc1 #721

Merged
merged 3 commits into from
Jan 19, 2022
Merged

Upgrade to SDK v0.45.0-rc1 #721

merged 3 commits into from
Jan 19, 2022

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jan 17, 2022 •
edited
Loading

@alpe alpe mentioned this pull request Jan 17, 2022
Closed
@alpe alpe requested a review from ethanfrey January 17, 2022 10:34
@codecov
Copy link

codecov bot commented Jan 17, 2022 •
edited
Loading

Codecov Report

Merging #721 (97e0cc9) into 501-sdk_upgrade_v0445 (3d2affb) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##           501-sdk_upgrade_v0445     #721      +/-   ##
=========================================================
+ Coverage                  59.89%   59.96%   +0.06%     
=========================================================
  Files                         48       48              
  Lines                       5585     5592       +7     
=========================================================
+ Hits                        3345     3353       +8     
+ Misses                      1998     1996       -2     
- Partials                     242      243       +1
Impacted Files Coverage Δ
app/app.go 88.34% <100.00%> (+0.21%) ⬆️
x/wasm/keeper/keeper.go 87.54% <0.00%> (-0.36%) ⬇️
x/wasm/module.go 48.31% <0.00%> (+3.37%) ⬆️

ethanfrey
ethanfrey approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks for getting this working.
curious about the extra end blockers, but looks good if the ci is happy

app/app.go Show resolved Hide resolved
@ethanfrey ethanfrey mentioned this pull request Jan 19, 2022
Closed
@ethanfrey ethanfrey merged commit 2c2a6eb into 501-sdk_upgrade_v0445 Jan 19, 2022
@alpe alpe deleted the 501-sdk_upgrade_v0450rc1 branch May 10, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alpe @ethanfrey