imp: allow cgo while disabling libwasmvm linking #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Marking as r4r. See cosmos/ibc-go#5923 (comment) Tested compiling with cgo enabled and using the custom build switch added here and had success! |
damiannolan
commented
Mar 26, 2024
|
@mergify rebase release/2.0 |
☑️ Nothing to do
|
|
@mergify backport release/2.0 |
✅ Backports have been created
|
webmaster128
added a commit
that referenced
this pull request
Mar 29, 2024
imp: allow cgo while disabling libwasmvm linking (backport #527)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed via comms channels.
I will test this for the usecase mentioned with ibc
08-wasmbefore publishing the PR as ready for review.This is the associated PR on ibc-go: cosmos/ibc-go#5923
And please let me know if I am missing something! 🖤