Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imp: allow cgo while disabling libwasmvm linking (backport #527) #530

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 29, 2024

As discussed via comms channels.

  • Adds the ability to enable cgo but disable libwasmvm in binary compliation.

I will test this for the usecase mentioned with ibc 08-wasm before publishing the PR as ready for review.
This is the associated PR on ibc-go: cosmos/ibc-go#5923

And please let me know if I am missing something! 🖤


This is an automatic backport of pull request #527 done by Mergify.

@mergify mergify bot added the conflicts label Mar 29, 2024
Copy link
Author

mergify bot commented Mar 29, 2024

Cherry-pick of bcde382 has failed:

On branch mergify/bp/release/2.0/pr-527
Your branch is ahead of 'origin/release/2.0' by 5 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit bcde382.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   lib.go
	new file:   lib_libwasmvm.go
	new file:   lib_libwasmvm_test.go
	deleted:    lib_no_cgo.go
	modified:   lib_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: lib_no_cgo_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@webmaster128 webmaster128 merged commit ae9defe into release/2.0 Mar 29, 2024
14 checks passed
@webmaster128 webmaster128 deleted the mergify/bp/release/2.0/pr-527 branch March 29, 2024 17:55
@webmaster128 webmaster128 added this to the 2.0.1 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants