[M1 Mac] Godot crashes on opening project with plugin installed #337
Comments
Video demonstrating installation & crashgodot-orchestrator-crash.mp4 |
|
Have you tried running it without the git plugin? I have now discovered that the same thing happens to me on Linux if the project has a git plugin. Without git plugin, Orchestrator plugin works fine. For some reason everything works fine for example with limboAI plugin and Orchestrator plugin, very strange. |
|
That's a great find @legbo, could it actually be that the git-plugin is the problem here working with GDExtensions? |
|
@Naros I tested Orchestrator plugin and latest Jolt extension and all is working fine together. But with random plugin from Asset library like Godot Steam not working, project (editor) started but then crashed. I tried to start plugins (Git, LimboAI, GodotSteam, Jolt) one by one without Orchestrator, and all is working fine. Console output, Orchestrator with Godot Steam: Console output, Orchestrator with Git plugin: |
|
When I try to run from the console, I get the below error. Removing the Godot git plugin (https://github.com/godotengine/godot-git-plugin) lets me boot up the project. So seems like there is some issue with the two existing at the same time as you two have stated. 😄 |
|
So what all these have in common is writing to the I really do not grok what causes this problem. We originally had issues with the logger on certain distributions that were using some really odd compiler switches to their distributions, such as Arch Linux, that were not including some standard C++ library functions that caused crashes. We rolled that back to pure C, but it seems to be an issue on MacOS. Overall this points to the logger, could this be a permissions issue writing to |
|
hi @legbo so this stack trace is interesting: This actually doesn't indicate an issue with Orchestrator but rather an issue between Godot and GLIBC. Our bool OScriptNode::_is_in_editor()
{
return OS::get_singleton()->has_feature("editor");
}This would indicate that either (a) the OS singleton is null, which is a Godot build issue. Or it indicates that there is an issue with the underlying Godot calls internally that resolve whether the editor feature is or is not enabled. What version of GLIBC is installed? Additionally, this also smells of a GLIBC compatibility issue: |
|
|
I have the same issue with Orchestrator on Linux, once both git and orchestrator are installed godot no longer starts. GLIBC |
|
Hi @RoyvanEmpel can you provide information about what Linux OS, distribution and patch level, including what version of git you installed. Thanks. |
|
Hi 👋🏻, don't know what you mean with patch level but here if the other info you asked for: OS: Kubuntu 23.10 Can i provide any more info? |
|
Hi @RoyvanEmpel I finally got Kubuntu 23.10 downloaded and installed into a VM. I installed Godot 4.2.2-stable from the official Godot website and downloaded the 2.0.1-stable Orchestrator plug-in and I don't experience any crash. Orchestrator: 2.0.1.stable.official [d1cae2ae0] Kubuntu: 23.10 Are you using any specific locale set-up? |
Did you install the official git plugin? |
|
Which version @chipsenkbeil because in Godot 4.2.2-stable, the git plugin v3.1.1 from the AssetLib doesn't enable, throws an error that there is a problem with one of its gd scripts. |
|
So I restarted the editor after installing the godot-git-plugin, and the console showed this error: If I create a project with just the So I'm inclined to say the git plugin is not compatible with Godot 4.2.2-stable. |
It was v3.1.1 that I used. But you don't enable the plugin, you just install it according to the docs: https://github.com/godotengine/godot-git-plugin/wiki/Git-plugin-v3 
The plugin does work because I used it just fine before installing orchestrator. |
|
Ah, in that case the plugin really shouldn't distribute a |
|
I wonder if this is somehow related to the C++ libraries being loaded by the two libraries: godot-git-plugin orchestrator This is somehow likely related to this in CMAKE: IF (NOT APPLE)
# Linker options for the GDExtension library
TARGET_LINK_OPTIONS(${PROJECT_NAME} PRIVATE
$<$<NOT:${compiler_is_msvc}>:
-static-libgcc
-static-libstdc++
-Wl,-R,'$$ORIGIN'
>
)
ENDIF ()Anyone have any suggestions? If we didn't statically link like this, we were having issues with pthreads when running on linux. |
|
Some clash in libraries makes sense, but I'm using a Mac - the original source of this issue - so wouldn't the CMAKE change not be applicable to me if there's a conditional of Seems like it would be good to open an issue with the official Godot git plugin as well to see if the two projects can work together to find a solution, right? |
|
So this is looking more and more like it could be a Godot bug. I recompiled the editor and both plugins on the same Kubuntu machine and I am seeing that |
Hi @Naros I have tried both The release build of orchestrator on the asset lib and the 2.1.dev2 release. KDE Plasma: 5.27.8 I am using a different (dutch) locale on my system to get the correct date/time and number formats for everything. I noticed that you created an issue at the git-plugin, hopefully there will be a response :) |
|
I rolled the I've also opened a dialogue about this on the Godot RocketChat #gdextension channel to hopefully get some answers, in case Hugo doesn't get to my ping on GitHub. |
Appreciate all of your investigative work here! Know it's been time consuming! |
|
So we found the culprit and its related to godotengine/godot-cpp#1313. This will be backported to the 4.1 branch on the next 4.1 release; until then unfortunately the godot-git-plugin will remain incompatible with Godot 4.2 based GDExtensions until it is rebuilt based on that 4.1 godot-cpp change or until the plugin updates to godot-cpp 4.2. |
I'd consider that a win! Is there a tracking issue on the godot side for this backport and update of Godot git plugin? I'd like to close this out since it's no longer an issue with Orchestrator but with Godot and the Git plugin, but want to leave a paper trail. |
|
Hi @chipsenkbeil this was backported to Godot 4.1 here => godotengine/godot-cpp#1491 I'm going to proceed with closing this issue since the code has been merged on Godot's side. |
Describe the bug
After installing the plugin via the asset library, ensuring it is placed within the addons library, Godot can no longer load the project. Every time I select the project, the Godot engine crashes.
I do have the official Git Godot plugin (https://github.com/godotengine/godot-git-plugin) version v3.1.1 installed within the addons directory prior to installing Orchestrator.
Expected behavior
No crash occurs.
Actual behavior
Engine crashes upon loading the project.
How to Reproduce?
Using an M1 Mac, install Godot 4.2.2.
From there, using the asset library, download the latest version of Orchestrator. Make sure to uncheck the ignore root box such that it installs in the addons directory.
Select "Save and Restart" when prompted.
Observe that Godot reports it crashed. On future loading, the project selection dialog is presented, and selecting the project will crash the engine.
Godot full version
v4.2.2.stable.official [15073afe3]
Orchestrator version
2.0.1:
Additional information
Using an M1 Mac Mini with MacOS Sonoma 14.4.1.
The text was updated successfully, but these errors were encountered: