Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for the godot-cpp 4.1 branch - 11th batch #1491

Merged
merged 7 commits into from
Jun 14, 2024

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Jun 14, 2024

The 11th batch of PR's marked with cherrypick:4.1

@dsnopek
Copy link
Collaborator Author

dsnopek commented Jun 14, 2024

Ugh. This is failing CI because it's running the tests with Godot master, rather than Godot 4.1. :-/ On the one hand, it's nice running against master, because that tells us we did a good job with backwards compatibility. But on the other hand, the 4.1 branch should probably be tested against Godot 4.1, to ensure we still work with that version, AND to avoid issues like this...

@AThousandShips
Copy link
Member

Might be worth to swap branch for right now and discuss how to proceed later just to make sure we can run and work with everything

@dsnopek dsnopek merged commit 2e7f551 into godotengine:4.1 Jun 14, 2024
12 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants