Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-421 Bump to godot-cpp 4.3-beta2 #422

Merged
merged 8 commits into from
Jun 30, 2024
Merged

GH-421 Bump to godot-cpp 4.3-beta2 #422

merged 8 commits into from
Jun 30, 2024

Conversation

Naros
Copy link
Member

@Naros Naros commented Jun 18, 2024

Fixes #421

@Naros Naros added the requires/godot-4.3 Requires Godot 4.3 label Jun 18, 2024
@Naros Naros added this to the 2.1 milestone Jun 18, 2024
@Naros
Copy link
Member Author

Naros commented Jun 19, 2024

Build fails due to godotengine/godot-cpp#1497

@Naros Naros changed the title GH-421 Bump to godot-cpp 4.3-beta1 - 45be6d0bd4e6901d47d97bed2a18af0f76450eab GH-421 Bump to godot-cpp 4.3-beta2 Jun 29, 2024
@Naros Naros merged commit cc8e799 into CraterCrash:main Jun 30, 2024
8 checks passed
@Naros Naros deleted the GH-421 branch June 30, 2024 03:01
@Naros
Copy link
Member Author

Naros commented Jun 30, 2024

Applied to main (=2.1).

@aaronfranke
Copy link
Contributor

@Naros For the #if GODOT_VERSION >= 0x040400 guards in the "Add compile-time support for Godot 4.3.beta2+" commit, it doesn't work in the latest godot-cpp master with commits for Godot 4.4-dev2. However, it compiles if I change the "version_minor" in the API JSON from 4 back to 3.

I'm confused, what was the reason for introducing things like calls to reset_state() in a check for Godot 4.4+? Is there a PR somewhere to expose this function? At the moment it is not in the exposed API, so compiling just breaks:

src/script/serialization/binary_saver_instance.cpp:856:23: error: no member named 'set_edited' in 'godot::Resource'
  856 |             resource->set_edited(false);
      |             ~~~~~~~~~~^
1 error generated.
make[3]: *** [CMakeFiles/orchestrator.dir/src/script/serialization/binary_saver_instance.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
src/script/serialization/binary_loader_instance.cpp:1004:25: error: no member named 'reset_state' in 'godot::Resource'
 1004 |                 cached->reset_state();
      |                 ~~~~~~~~^
src/script/serialization/binary_loader_instance.cpp:1107:14: error: no member named 'set_edited' in 'godot::Resource'
 1107 |         res->set_edited(false);
      |         ~~~~~^
2 errors generated.
make[3]: *** [CMakeFiles/orchestrator.dir/src/script/serialization/binary_loader_instance.cpp.o] Error 1
src/script/serialization/text_loader_instance.cpp:186:26: error: no member named 'set_id_for_path' in 'godot::Resource'
  186 |                     res->set_id_for_path(_local_path, id);
      |                     ~~~~~^
src/script/serialization/text_loader_instance.cpp:658:22: error: no member named 'reset_state' in 'godot::Resource'
  658 |                 res->reset_state();
      |                 ~~~~~^
src/script/serialization/text_loader_instance.cpp:728:22: error: no member named 'set_path_cache' in 'godot::Resource'
  728 |                 res->set_path_cache(path);
      |                 ~~~~~^
src/script/serialization/text_loader_instance.cpp:823:14: error: no member named 'reset_state' in 'godot::Resource'
  823 |                     cache->reset_state();
      |                     ~~~~~~~^
src/script/serialization/text_loader_instance.cpp:887:18: error: no member named 'set_as_translation_remapped' in 'godot::Resource'
  887 |                                                 _resource->set_as_translation_remapped(_translation_remapped);
      |                                                 ~~~~~~~~~~~^
src/script/serialization/text_loader_instance.cpp:893:27: error: no member named 'set_path_cache' in 'godot::Resource'
  893 |                                     _resource->set_path_cache(_res_path);
      |                                     ~~~~~~~~~~~^
6 errors generated.

@Naros
Copy link
Member Author

Naros commented Sep 21, 2024

There is @aaronfranke, see godotengine/godot#90969. It's approved, I just need to address Remi's latest review comments, which I intended to follow-up on this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires/godot-4.3 Requires Godot 4.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump godot-cpp to 4.3-beta2
2 participants