Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing enum & ctor for PackedVector4Array implementation #1497

Merged

Conversation

Naros
Copy link
Contributor

@Naros Naros commented Jun 19, 2024

@dsnopek I think this may have been overlooked in #1456

@dsnopek
Copy link
Collaborator

dsnopek commented Jun 19, 2024

Thanks!

However, this only appears to update variant.hpp - shouldn't the implementations for these methods need to be added to variant.cpp as well?

@Naros
Copy link
Contributor Author

Naros commented Jun 19, 2024

Thanks!

However, this only appears to update variant.hpp - shouldn't the implementations for these methods need to be added to variant.cpp as well?

Ya it does, fixed the PR.

@Naros Naros force-pushed the fix-variant-hpp-packed-vector4-array branch from 0167d65 to 78b6320 Compare June 19, 2024 15:21
@Naros Naros requested a review from akien-mga June 19, 2024 15:21
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I haven't tested it, but the code looks good to me. Assuming this passes CI, I think it's good to go :-)

@dsnopek dsnopek merged commit 90c6ea2 into godotengine:master Jun 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants