Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASM-3864: Clean up files in /tmp after execution #5583

Draft
wants to merge 3 commits into
base: release/1.6
Choose a base branch
from
Draft

CASM-3864: Clean up files in /tmp after execution #5583

wants to merge 3 commits into from

Conversation

Srinivas-Anand-HPE
Copy link
Contributor

Summary and Scope

Clean up files with random file name in /tmp directory from nodes in iuf/nls workflows . Remove these files when we're done in same workflow

CASM-3864

Checklist

  • If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
  • If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
  • My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

rajeshranganathan-hpe
rajeshranganathan-hpe approved these changes Dec 3, 2024
View reviewed changes
workflows/templates/base/ssh.template.argo.yaml Outdated Show resolved Hide resolved
workflows/templates/storage.create-rgw-buckets.yaml Outdated Show resolved Hide resolved
workflows/templates/storage.shutdown-services.yaml Outdated Show resolved Hide resolved
workflows/templates/storage.shutdown-services.yaml Outdated Show resolved Hide resolved
workflows/templates/wipe-and-reboot-worker.yaml Outdated Show resolved Hide resolved
@Srinivas-Anand-HPE Srinivas-Anand-HPE marked this pull request as ready for review December 4, 2024 06:45
@Srinivas-Anand-HPE Srinivas-Anand-HPE requested a review from a team as a code owner December 4, 2024 06:45
leliasen-hpe
leliasen-hpe approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@leliasen-hpe leliasen-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving this. I just want to make sure this has been tested and worked fine? Since this is going strait into CSM 1.6 we need to make sure it has been tested thoroughly.

leliasen-hpe
leliasen-hpe requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@leliasen-hpe leliasen-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put these changes on feature/iuf-improvements-1.6.1 branch and not to relase/1.6

@Srinivas-Anand-HPE Srinivas-Anand-HPE marked this pull request as draft December 4, 2024 17:54
Srinivas-Anand-HPE and others added 3 commits December 9, 2024 15:31
@Srinivas-Anand-HPE
CASMINST-6734: SW_ADMIN_PASSWORD variable is not required to be set f…
402a753 
…or tests anymore #5562 (#5591)

CASMINST-6734: SW_ADMIN_PASSWORD variable is not required to be set for tests anymore
@Srinivas-Anand-HPE
CASM-4713 Remove prometheus logging #5551 (#5592)
86ab6a3 
* CASM-4713: Remove prometheus logging - main container

* CASM-4713: Remove prometheus logging - prom-metrics pod

* Remove prom-metrics logs in iuf sample output
@Srinivas-Anand-HPE
CASM-3864: Clean up files in /tmp after execution
38aa3ec
Srinivas-Anand-HPE added a commit that referenced this pull request Dec 9, 2024
@Srinivas-Anand-HPE
CASM-3864: Clean up files in /tmp after execution #5583 (#5590)
f4f61a1 
CASM-3864: Clean up files in /tmp after execution
@github-actions GitHub Actions
Copy link
Contributor

This pull-request has not had activity in over 20 days and is being marked as stale.

@github-actions github-actions bot added the Stale Hasn't had activity in over 30 days label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leliasen-hpe leliasen-hpe leliasen-hpe requested changes

@Pankhuri-Rajesh Pankhuri-Rajesh Pankhuri-Rajesh approved these changes

@rajeshranganathan-hpe rajeshranganathan-hpe rajeshranganathan-hpe approved these changes

@atifsyedali atifsyedali Awaiting requested review from atifsyedali

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Stale Hasn't had activity in over 30 days
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Srinivas-Anand-HPE @leliasen-hpe @rajeshranganathan-hpe @Pankhuri-Rajesh