Set mem hook #1
Merged
Set mem hook #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t slurm) don't accept fractional memory requests. Rounding in MB we introduce less error
…SLURM takes gigabytes (base-10). Torque supposedly takes mebibytes (base-2).
…e for large task counts
This was referenced May 22, 2024
Crivella
reviewed
May 23, 2024
casparvl
commented
May 23, 2024
Fix CI issues Co-authored-by: Davide Grassano <34096612+Crivella@users.noreply.github.com>
Apply fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should do it. The function requesting a certain amount of memory for the QE test is fictional - I haven't checked the memory footprint for the QE tests for all sizes. That's an exercise I leave for you as developer of the test to fill in :D It does seem to at least be sufficient: all the tests pass on the system where they were failing before, even for the 1/2/4 core count cases.
Probably, we should at least have different functions for the different use cases. The smallest use case can probably run with a lot less memory as well :) A linear function is probably also a bad approximation, but since the memory requirements are not excessive (most HPC nodes have at least 1 GB per core), 'worst case' it now asks for a bit too much...