Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set mem hook #1

Merged
merged 8 commits into from
May 23, 2024
Merged

Set mem hook #1

merged 8 commits into from
May 23, 2024

Commits on May 16, 2024

  1. Add available memory for one of the Snellius partitions, for testing

    Caspar van Leeuwen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    6f2c2db View commit details
    Browse the repository at this point in the history

  2. Implement hook for requesting memory from the scheduler

    Caspar van Leeuwen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d1c7f74 View commit details
    Browse the repository at this point in the history

  3. Convert to MB before requesting the scheduler, as schedulers (at leas… 

    …t slurm) don't accept fractional memory requests. Rounding in MB we introduce less error
    Caspar van Leeuwen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4242927 View commit details
    Browse the repository at this point in the history

  4. Make sure all user defined inputs are in base-2, i.e. gibibytes etc. … 

    …SLURM takes gigabytes (base-10). Torque supposedly takes mebibytes (base-2).
    Caspar van Leeuwen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    4b87213 View commit details
    Browse the repository at this point in the history

  5. Make memory requirement tighter, so that we don't exceed the 1 GB/cor… 

    …e for large task counts
    Caspar van Leeuwen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e2de0ee View commit details
    Browse the repository at this point in the history

  6. Add some memory for standard system configs. Will do aws_mc later...

    Caspar van Leeuwen committed May 16, 2024
    Configuration menu
    Copy the full SHA
    48878d1 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Apply suggestions from code review 

    Fix CI issues

Co-authored-by: Davide Grassano <34096612+Crivella@users.noreply.github.com>
    @casparvl @Crivella
    casparvl and Crivella authored May 23, 2024
    Configuration menu
    Copy the full SHA
    94e6161 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Apply fixes
    @Crivella
    Crivella authored May 23, 2024
    Configuration menu
    Copy the full SHA
    360df65 View commit details
    Browse the repository at this point in the history