-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Issues/Bugs (affected v2.5.2): Exporting seed analysis to CSV #122
Comments
The seed analysis can now use the matching seed list as input in v2.3.0. |
Several issues/problems with the matching seed list input in v2.3.0 release. (Updated to include v2.3.3 release as it the issues are still affected)
This could be resolved by having each seed printed on a single line when the "matching seed list" is toggled, which would reduce filesize, since each biome/structure would be listed in the first column. Note that biomes/structures that aren't found in the area would need to be marked as 0. so the columns align properly for each seed. Proper example:
This might be a problem if a user analyzes structure locations, but that option should problably be restricted to number of structures and no structure locations if "matching seed list" is toggled.
|
Affects v2.4.0 and v2.4.1 |
The analysis function has been completely redesigned now for v2.5.0 with many of these issues in mind. |
It seems though the analysis of biomes using a seed list function still causes the program to hang in v2.5.0. It's probably best to have the default behavior for analysis of biomes with a seed list to automatically ask the user to export to CSV if there is more than 64 seeds in the seed list, and avoid displaying hundreds of seeds biome analysis in the GUI, otherwise the program will hang. |
The analysis is run in a different thread and, when used with the matching seed list, it notifies the UI to update on every seed that finishes and should not block the UI. Furthermore, the analysis can be aborted at any time, even while a single seed is examined. |
I did some more testing, trying to reproduce your hanging issue and I found that with a large seed list, the biome statistics table starts to struggle, but only on Windows. I'm guessing this is what you are experiencing. Qt's implementation of a table on Windows is apparently not very performant can cannot handle that many updates when the table has reached a certain size. A mitigation might by to limit the updates to the table and only update every 10 or 100 seeds later on... |
I have changed how the UI is updated when a seed is analyzed. It's a workaround that somewhat goes against Qt advice, but it should have significantly less performance issues and should hopefully no longer cause the tool to become unresponsive. |
It's a bit better, but the GUI still slows down after thousands of seeds analyzed, and the analyzer speed then slows as well, so a direct export to CSV is still helpful. but it would be much more improved if the rows and columns could be swapped for the seed lists, to have seed lists have the seeds by row, and biomes in column. Also, the separating value should be a "," not ";". Additional fixes that need to be made for v2.5.2+:
|
* added UI event buffering to the anaylsis results, making it much more performant with many seeds (#122) * added custom separator option for csv export (#122) * added DejaVuSans monospace font for a more consistent look (#107) * added filter for biome center locations with scale 1:256 for versions up to 1.17 (#63) * changed biome statistics UI to display seeds as rows (#122) * changed matching seed list and some anaylsis results to be tristate sortable * changed zoom limits for the goto dialog, allowing a larger manual zoom range (#162) * changed abandoned village and end ship modifiers to be a tristate with exclude option (#168) * fixed incorrect progress display for anaylses (#165) * fixed stronghold filter so it doesn't skip the last inner ring stronghold (#171) * fixed slightly inaccurate biome check location for some villages and bastions (#168) * + few more minor fixes and tweaks
I have tried to address UI performance issue again in the update 2.6.0. The UI will now only receive updates as long as it does not affect the calculations to a significant degree.
I have added two new options to the settings menu, where the column separator and cell quotation can be specified. This is probably the best I can offer regarding this. |
As the title says.
For the GUI analyer, it should be able to analyze either the existing list of seeds in the GUI, or analyze a file of seeds, and it would output the results to a csv file.
The text was updated successfully, but these errors were encountered: