Update GitHub Actions

[DimitriPapadopoulos]

Unfortunately tipi-build-linux fails with:

● [err] Dynamic exception type: std::runtime_error
std::exception::what: can not create git repository [-3] - config value 'safe.directory' was not found

● [err] Something went wrong, for help on your issue, we would enjoy getting your report at https://tipi.build/#contact
Error: Process completed with exit code 1.

[t-mat]

Hi @DimitriPapadopoulos , thanks for the PR. I also don't understand what happens with tipi.

● [err] Something went wrong, for help on your issue, we would enjoy getting your report at https://tipi.build/#contact
Error: Process completed with exit code 1.

@pysco68 , since I think we're not cutomer of the tipi.build service, we can't contact/report this issue directly.
Could you help us to resolve this issue?

[DimitriPapadopoulos]

The strange thing is that reverting my change for tipi-build-linux fails too. I don't know what tipi is, and the error message does not really help:

config value 'safe.directory' was not found

[DimitriPapadopoulos]

https://git-scm.com/docs/git-config#Documentation/git-config.txt-safedirectory

safe.directory

These config entries specify Git-tracked directories that are considered safe even if they are owned by someone other than the current user. By default, Git will refuse to even parse a Git config of a repository owned by someone else, let alone run its hooks, and this config setting allows users to specify exceptions, e.g. for intentionally shared repositories [...]

[DimitriPapadopoulos]

While this is only a warning, I think it's the same problem:

▼ Run mkdir -p ~/.tipi
 mkdir -p ~/.tipi
 shell: sh -e {0}
 env:
   HOME: /root
WARNING: Error loading config file: /root/.docker/config.json: open /root/.docker/config.json: permission denied

[DimitriPapadopoulos]

I'll try to revert again from v3 to v2, I must have done something wrong when reverting last time:

▼ Run actions/checkout@v3
  with:
    repository: Cyan4973/xxHash
    token: ***
    ssh-strict: true
    persist-credentials: true
    clean: true
    fetch-depth: 1
    lfs: false
    submodules: false
    set-safe-directory: true
  env:
    HOME: /root
/usr/bin/docker exec  84ed8eaf7dd9f6139174d1635c373866149763118b56d824b2efebbf58d81c60 sh -c "cat /etc/*release | grep ^ID"
WARNING: Error loading config file: /root/.docker/config.json: open /root/.docker/config.json: permission denied
Syncing repository: Cyan4973/xxHash
▼ Getting Git version info
  Working directory is '/__w/xxHash/xxHash'
  /usr/bin/git version
  git version 2.25.1

[DimitriPapadopoulos]

We get the same errorr with v2:

▼ Run actions/checkout@v2
  with:
    repository: Cyan4973/xxHash
    token: ***
    ssh-strict: true
    persist-credentials: true
    clean: true
    fetch-depth: 1
    lfs: false
    submodules: false
    set-safe-directory: true
  env:
    HOME: /root
/usr/bin/docker exec  e272b64d51a78baf0f1958fe1d1bbfd3c13999a74103a39be35407b1d6bd4944 sh -c "cat /etc/*release | grep ^ID"
WARNING: Error loading config file: /root/.docker/config.json: open /root/.docker/config.json: permission denied
Syncing repository: Cyan4973/xxHash
▼ Getting Git version info
  Working directory is '/__w/xxHash/xxHash'
  /usr/bin/git version
  git version 2.25.1

● [err] Dynamic exception type: std::runtime_error
std::exception::what: can not create git repository [-3] - config value 'safe.directory' was not found

● [err] Something went wrong, for help on your issue, we would enjoy getting your report at https://tipi.build/#contact

It looks like a tipi new bug, unrelated to this merge request.

[Cyan4973]

The proposed PR looks good to me.
The CI test issue seems to be on the tipi side.

[Cyan4973]

It looks like Github Action tests are no longer active right after this PR.

Investigation ongoing ...

[DimitriPapadopoulos]

But tests were working on my branch before merging, weren't they?

[DimitriPapadopoulos]

I see them not working after 63356da, but it's tipi not working, again:

I don't see how this PR could be involved.

[DimitriPapadopoulos]

/usr/local/share/.tipi/w/cli-89765bc/xsum_bench.c:33:10: error: '../xxhash.h' file not found, did you mean 'xxhash.h'?
#include "../xxhash.h"
         ^~~~~~~~~~~~~
         "xxhash.h"
[ 42%] Building C object CMakeFiles/cli-89765bc.dir/usr/local/share/.tipi/w/cli-89765bc/xsum_sanity_check.c.o
1 error generated.

[t-mat]

@DimitriPapadopoulos sorry for bothering!
#758 and further PRs will resolve CI and tipi.build issues.

[Cyan4973]

Yeah, sorry for the noise @DimitriPapadopoulos ,
it's just a time coincidence,
the problem actually comes from another part of CI (tipi).