Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix missing space #758

Merged
merged 1 commit into from
Nov 10, 2022
Merged

CI: fix missing space #758

merged 1 commit into from
Nov 10, 2022

Conversation

hzhuang1
Copy link
Contributor

Missing space caused that github action doesn't work.

Signed-off-by: Haojian Zhuang haojian.zhuang@linaro.org

@hzhuang1
CI: fix missing space
63356da 
Missing space caused that github action doesn't work.

Signed-off-by: Haojian Zhuang <haojian.zhuang@linaro.org>
@t-mat
Copy link
Contributor

t-mat commented Nov 10, 2022

Thanks. It's working now 🎉

image

@t-mat t-mat mentioned this pull request Nov 10, 2022
Closed
@hzhuang1
Copy link
Contributor Author

Thanks. It's working now 🎉

image

Thanks for your guide. Whatever it's the issue that is imported by me.

@hzhuang1
Copy link
Contributor Author

Screen Shot 2022-11-10 at 10 42 4@t-mat

@t-mat Oh, there's still a tipi issue.

@t-mat
Copy link
Contributor

t-mat commented Nov 10, 2022 •
edited
Loading

Right. It seems tipi.build system is still hitting some issue. 😿

https://github.com/Cyan4973/xxHash/actions/runs/3433505455/jobs/5723893397#step:8:10075

image

@Cyan4973 can we comment out tipi.build for now?

edit:
Our status

  • This PR fixes YAML syntax error in ci.yml.
  • Now GitHub actions is working properly.
  • But tipi.build test is failing with different and misterious error.

@Cyan4973
Copy link
Owner

I believe tipi.build should not be part of xxHash CI test suite.
We shall remove it.

@Cyan4973
Copy link
Owner

Thanks for finding and fixing the core issue @hzhuang1 !

@Cyan4973 Cyan4973 merged commit 8e94343 into Cyan4973:dev Nov 10, 2022
@t-mat t-mat mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hzhuang1 @t-mat @Cyan4973