-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ibis extension registration #737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add instructions on what to do if you hit this error (+ maybe related github issue?). Should be part of the error message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Performed an incremental review on 211d47a
- Looked at
15
lines of code in1
files - Took 1 minute and 25 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. hamilton/plugins/ibis_extensions.py:29
:
- Assessed confidence :
0%
- Comment:
The changes made to thefill_with_scalar_ibis
function are in line with the PR description and do not seem to introduce any new bugs or violate any best practices. - Reasoning:
The changes in the PR are minimal and seem to be in line with the PR description. The function fill_with_scalar_ibis is already raising a NotImplementedError, and the PR just modifies the way the error message is displayed (splitting it into two lines instead of one). This doesn't seem to introduce any new bugs or violate any best practices.
Workflow ID: wflow_gVdNLA9rvas8ZsZ2
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me!
- Performed an incremental review on 5442f0b
- Looked at
24
lines of code in1
files - Took 1 minute and 30 seconds to review
More info
- Skipped
0
files when reviewing. - Skipped posting
1
additional comments because they didn't meet confidence threshold of50%
.
1. hamilton/plugins/ibis_extensions.py:28
:
- Assessed confidence :
0%
- Comment:
The placeholder function and its registration look good. The use of NotImplementedError is a good practice for placeholder functions. - Reasoning:
The PR seems to be in order. The author has added a placeholder function for 'fill_with_scalar_ibis' and registered it. The function raises a NotImplementedError, which is a good practice for placeholder functions. The code is clean, follows the DRY principle, and doesn't contain any secrets or credentials. The function and method naming also follow consistent patterns. There are no apparent logical, performance, or security bugs. The PR description is clear and matches the changes made.
Workflow ID: wflow_8GrjwnthDp6WKLF5
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Dataframe extensions need to register functions:
Changes
Summary:
This PR adds and modifies the
fill_with_scalar_ibis
function inibis_extensions.py
, registering it with thefill_with_scalar
registry and indicating that filling Ibis columns with scalars is not yet supported.Key points:
fill_with_scalar_ibis
function inibis_extensions.py
.fill_with_scalar_ibis
with thefill_with_scalar
registry.NotImplementedError
, indicating that filling Ibis columns with scalars is not supported.Generated with ❤️ by ellipsis.dev