Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ibis extension registration #737

Merged
merged 4 commits into from
Mar 5, 2024
Merged

fix: ibis extension registration #737

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
794a6d8
fix registry
Mar 5, 2024
57d60c0
Update ibis_extensions.py
zilto Mar 5, 2024
5568803
added error message
zilto Mar 5, 2024
211d47a
pre-commit hooks
zilto Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion hamilton/plugins/ibis_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Type
from typing import Any, Type

from hamilton import registry

Expand All @@ -24,6 +24,13 @@ def register_types():
registry.register_types("ibis", DATAFRAME_TYPE, COLUMN_TYPE)


@registry.fill_with_scalar.register(ir.Table)
def fill_with_scalar_ibis(df: ir.Table, column_name: str, scalar_value: Any) -> ir.Table:
raise NotImplementedError(
"As of Hamilton version 1.5.1, filling Ibis columns with scalars isn't supported. This feature is actively being developed"
)


register_types()


Expand Down