Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skips polars DB test on 3.12 #777

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Skips polars DB test on 3.12 #777

merged 1 commit into from
Mar 22, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Mar 22, 2024

Why? It complains about connectorx not being installed. But it is! and this only happens on python 3.12. Since python 3.12 is so new, likely something has changed in polars or connectorx. So skipping test for now on 3.12.

Changes

  • polars extension test

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Why? It complains about connectorx not being installed.
But it is! and this only happens on python 3.12. Since
python 3.12 is so new, likely something has changed
in polars or connectorx. So skipping test for now on
3.12.
@skrawcz skrawcz merged commit 269044f into main Mar 22, 2024
0 of 5 checks passed
@skrawcz skrawcz deleted the skip_polars_test branch March 22, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant