Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/dagster and docs/code-comparison/dagster #779

Merged
merged 5 commits into from
Mar 23, 2024
Merged

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Mar 22, 2024

This is cleaned up version of the git history of #772

Added a code comparison page for Dagster and an example folder.

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@zilto zilto added the documentation Improvements or additions to documentation label Mar 22, 2024
@zilto zilto requested a review from skrawcz March 22, 2024 19:59
@skrawcz
Copy link
Collaborator

skrawcz commented Mar 22, 2024

I think this can be squash merged as a single commit.

@zilto zilto merged commit 7a34277 into main Mar 23, 2024
23 checks passed
@zilto zilto deleted the examples/dagster2 branch March 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants