Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/integrations Dagster #772

Closed
wants to merge 13 commits into from
Closed

docs/integrations Dagster #772

wants to merge 13 commits into from

Conversation

zilto
Copy link
Collaborator

@zilto zilto commented Mar 21, 2024

Comparison table with Dagster

Changes

  • added a docs page
  • added code snippets and figures

How I tested this

  • built docs locally

Notes

  • WIP
  • examples/ will follow

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

zilto and others added 4 commits March 20, 2024 20:15
* reduced type constraints on JSON materializer

---------

Co-authored-by: zilto <tjean@DESKTOP-V6JDCS2>
@zilto zilto requested a review from skrawcz March 22, 2024 15:38
@zilto zilto added the documentation Improvements or additions to documentation label Mar 22, 2024
swapdewalkar and others added 2 commits March 22, 2024 09:18
* Polaris Database Read Writer, Unit Test, Materialization.

This adds materializer support for reading and writing to a DB with polars.
------------------------------------------------
Co-authored-by: swapdewalkar <swapdewalkar@gmail.com>
Why? It complains about connectorx not being installed.
But it is! and this only happens on python 3.12. Since
python 3.12 is so new, likely something has changed
in polars or connectorx. So skipping test for now on
3.12.
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just the one edit.

@skrawcz
Copy link
Collaborator

skrawcz commented Mar 22, 2024

Oh and we should have a notebook example for the Hamilton side of things please.

skrawcz and others added 7 commits March 22, 2024 11:17
* Fixes skipif logic

Argh, didn't properly evaluate the condition.
This should work now.

* Fixes isort issue by skipping it

Pre-commit run --all-files still has different behavior
than the pre-commit hook for me. This just tells isort
to skip things. I'm not sure where the discrepancy comes from.
@zilto zilto closed this Mar 22, 2024
@zilto zilto deleted the examples/dagster branch April 15, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants