-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/integrations
Dagster
#772
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reduced type constraints on JSON materializer --------- Co-authored-by: zilto <tjean@DESKTOP-V6JDCS2>
* Polaris Database Read Writer, Unit Test, Materialization. This adds materializer support for reading and writing to a DB with polars. ------------------------------------------------ Co-authored-by: swapdewalkar <swapdewalkar@gmail.com>
Why? It complains about connectorx not being installed. But it is! and this only happens on python 3.12. Since python 3.12 is so new, likely something has changed in polars or connectorx. So skipping test for now on 3.12.
skrawcz
reviewed
Mar 22, 2024
skrawcz
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just the one edit.
Oh and we should have a notebook example for the Hamilton side of things please. |
* Fixes skipif logic Argh, didn't properly evaluate the condition. This should work now. * Fixes isort issue by skipping it Pre-commit run --all-files still has different behavior than the pre-commit hook for me. This just tells isort to skip things. I'm not sure where the discrepancy comes from.
…milton into examples/dagster
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison table with Dagster
Changes
How I tested this
Notes
examples/
will followChecklist