Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post execution hook with preview #85

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Add post execution hook with preview #85

merged 3 commits into from
Feb 21, 2024

Conversation

brandomr
Copy link
Contributor

@brandomr brandomr commented Feb 20, 2024

Simple PR to add the post execution hook with the model response (not the full configuration wrapper) in the mira_config_edit context.

This also ensure support for previews of regnet + stock and flow on both the mira_config_edit context as well as the mira_model context.

@Tom-Szendrey
Copy link
Contributor

LGTM!
Thank you!

Here I have ran an update to set beta to 0 and gamma to 1 and got the expected response:
Sample updated model config.json

@brandomr brandomr marked this pull request as ready for review February 20, 2024 19:57
@brandomr
Copy link
Contributor Author

brandomr commented Feb 20, 2024

@Tom-Szendrey I went ahead and updated the model_preview.py in both mira_model and mira_config_edit contexts to ensure appropriate handling for regnet + stock and flow. im not sure whether the image will be generated correctly though so am testing now for regnets.

@Tom-Szendrey
Copy link
Contributor

Thanks Brandon! Can we merge this?

@brandomr brandomr merged commit 3c51254 into main Feb 21, 2024
2 checks passed
@mwdchang mwdchang deleted the model-config-preview branch August 15, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants