-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ts/2500 implement notebook beaker integrate within model config #2758
Merged
mwdchang
merged 26 commits into
main
from
TS/2500-implement-notebook-beaker-integrate-within-model-config
Feb 21, 2024
Merged
Ts/2500 implement notebook beaker integrate within model config #2758
mwdchang
merged 26 commits into
main
from
TS/2500-implement-notebook-beaker-integrate-within-model-config
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding tempConfigId
…S/2500-implement-notebook-beaker-integrate-within-model-config
…S/2500-implement-notebook-beaker-integrate-within-model-config
2 tasks
…S/2500-implement-notebook-beaker-integrate-within-model-config
…S/2500-implement-notebook-beaker-integrate-within-model-config
Tom-Szendrey
commented
Feb 20, 2024
packages/client/hmi-client/src/workflow/ops/model-config/tera-model-config.vue
Show resolved
Hide resolved
…S/2500-implement-notebook-beaker-integrate-within-model-config
blanchco
reviewed
Feb 20, 2024
packages/client/hmi-client/src/workflow/ops/model-config/tera-model-config.vue
Outdated
Show resolved
Hide resolved
mwdchang
requested changes
Feb 20, 2024
packages/client/hmi-client/src/workflow/ops/model-config/tera-model-config.vue
Show resolved
Hide resolved
packages/client/hmi-client/src/workflow/ops/model-config/tera-model-config.vue
Show resolved
Hide resolved
packages/client/hmi-client/src/workflow/ops/model-config/tera-model-config.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/workflow/ops/model-config/tera-model-config.vue
Outdated
Show resolved
Hide resolved
packages/client/hmi-client/src/workflow/ops/model-config/tera-model-config.vue
Show resolved
Hide resolved
…S/2500-implement-notebook-beaker-integrate-within-model-config
mwdchang
approved these changes
Feb 21, 2024
mwdchang
deleted the
TS/2500-implement-notebook-beaker-integrate-within-model-config
branch
February 21, 2024 16:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for 2 things - Sorry!
This adds the beaker context and components to the notebook side of things.
To do this we have had to add a temporary config to this drilldown so it has access to a configuration when there are none yet created. This can then be passed to beaker for reading and writing.
This updates how we are using local variables in this component to be more aligned with how we are doing that in every other component.
We are going
From state updates local, local sometimes updates state, wait for debounce to do things
To local updates state
Testing:
Please note I am testing with this branch of beaker for preview messages: DARPA-ASKEM/askem-beaker#85
Model.Config.mov
Should be able to:
Ask agent for snippets of code (not many only the 2 tools in the agent)
Write code you want and update the model_config object as well
Save changes
See results