Clear dataset columns when creating a new dataset #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user is saving a modified dataset there is a likelyhood that columns and/or data have changed, so the HMI-Server needs a clue that the columns information should be reset.
dvince2
added a commit
to DARPA-ASKEM/terarium
that referenced
this pull request
Feb 28, 2024
This is actually the fix for incorrect column information after a beaker-driven transform too. There is a corresponding change on beaker that blows away column data (DARPA-ASKEM/askem-beaker#95) since columns and/or data will have changed in modified datasets. Then on a GET call we repopulate the column data because its empty. This will also cover any situation where a CSV/dataset was some how uploaded and the column data was empty too. In addition, this centralizes some code around getting CSV files and updating headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user is saving a modified dataset there is a likelyhood that columns and/or data have changed, so the HMI-Server needs a clue that the columns information should be reset.