fix[hmi-server]: Dataset extract columns, doing it on GET if not present #2862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is actually the fix for incorrect column information after a beaker-driven transform too. There is a corresponding change on beaker that blows away column data (DARPA-ASKEM/askem-beaker#95) since columns and/or data will have changed in modified datasets. Then on a GET call we repopulate the column data because its empty. This will also cover any situation where a CSV/dataset was some how uploaded and the column data was empty too. In addition, this centralizes some code around getting CSV files and updating headers.
YohannParis
approved these changes
Feb 29, 2024
...ain/java/software/uncharted/terarium/hmiserver/controller/dataservice/DatasetController.java
Show resolved
Hide resolved
dvince2
deleted the
2784-dataset-extract-columns-doing-it-on-get-if-not-present
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is actually the fix for incorrect column information after a beaker-driven transform too. There is a corresponding change on beaker that blows away column data (DARPA-ASKEM/askem-beaker#95) since columns and/or data will have changed in modified datasets. Then on a GET call we repopulate the column data because its empty. This will also cover any situation where a CSV/dataset was some how uploaded and the column data was empty too. In addition, this centralizes some code around getting CSV files and updating headers.
Resolves #2784