Solving ensembles, and move tests to simulation-integration #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #148 +/- ##
==========================================
+ Coverage 78.06% 80.25% +2.18%
==========================================
Files 3 3
Lines 465 476 +11
==========================================
+ Hits 363 382 +19
+ Misses 102 94 -8 ☔ View full report in Codecov by Sentry. |
joshday
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #109
fixes #126
Simulate ensembles and simulate calibrates will solve through the service now. One limitation is that calibrate ensemble can not calibrate based on observables, only on the states. The SIR ensemble scenario in simulation-integration calls for this though. Additional functionality would need to be added to EasyModelAnalysis, if it's possible.
Changes and tweaks will likely need to be made, but the main functionality works. Tests now use the simulation-integration repo instead of local files as well.