Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: project table view #1869

Merged
merged 36 commits into from
Sep 21, 2023
Merged

feat: project table view #1869

merged 36 commits into from
Sep 21, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Sep 15, 2023

Description

  • Add a segmented control to toggle between cards and table view
  • Table can be filtered by adding or removing columns
  • Description can be expanded
  • Project titles are links that, when clicked, open the project
  • When a table row is hovered, its kebab menu icon is displayed

Video of row expansion:

Screen.Recording.2023-09-20.at.1.32.42.PM.mov

@shawnyama shawnyama linked an issue Sep 15, 2023 that may be closed by this pull request
@shawnyama shawnyama marked this pull request as ready for review September 19, 2023 19:23
@shawnyama
Copy link
Contributor Author

shawnyama commented Sep 19, 2023

Not sure why I am getting those linting errors because I am using those functions but they are read as unused...

@shawnyama shawnyama requested a review from blanchco September 19, 2023 19:43
@blanchco
Copy link
Contributor

blanchco commented Sep 19, 2023

Need some help identifying why two dialog boxes appear here. This happens with the cards too.

Screen.Recording.2023-09-19.at.3.31.21.PM.mov
Also not sure why I am getting those linting errors because I am using those functions but they are read as unused...

moving the dialog a couple levels in the templating helps, most likely something to do when indexing 🤷 :

		</Teleport>
		<Dialog
			:header="`Remove ${selectedProjectMenu?.name}`"
			v-model:visible="isRemoveDialog"
		>
			<p>
				You are about to remove project <em>{{ selectedProjectMenu?.name }}</em
				>.
			</p>
			<p>Are you sure?</p>
			<template #footer>
				<Button label="Cancel" class="p-button-secondary" @click="closeRemoveDialog" />
				<Button label="Remove project" @click="removeProject" />
			</template>
		</Dialog>
	</main>
</template>

@shawnyama shawnyama marked this pull request as draft September 20, 2023 15:40
@shawnyama shawnyama marked this pull request as ready for review September 20, 2023 17:40
Copy link
Contributor

@blanchco blanchco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , just need to fix those linter issues...

@shawnyama shawnyama merged commit e8ae6dc into main Sep 21, 2023
@shawnyama shawnyama deleted the project-table-view branch September 21, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: UX Design: Projects Table View
4 participants