feat: operation outputs #2276
Merged
feat: operation outputs #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mwdchang
reviewed
Nov 21, 2023
mwdchang
approved these changes
Nov 21, 2023
YohannParis
reviewed
Nov 22, 2023
| <span> | ||
| <label> | ||
| {{ getPortLabel(input) }} | ||
| {{ input.isOptional ? '(optional)' : '' }} |
There was a problem hiding this comment.
This should be part of the getPortLabel() function.
Comment on lines
+77
to
+80
| // Once dataset is selected | ||
| if (isEmpty(props.node.outputs)) { | ||
| emit('select-dataset', { id: dataset.value.id, name: dataset.value.name }); | ||
| } |
There was a problem hiding this comment.
I don't understand why we emit this event only when the outputs are empty?
Comment on lines
+2
to
+4
| <ul v-if="!isEmpty(outputs)"> | ||
| <li | ||
| v-for="(output, index) in outputs" |
There was a problem hiding this comment.
Isn't the v-for handling the case of an empty array?
Or is that outputs could be Just checked and the type forces an array, so I don't think the null or undefined?v-if="!isEmpty(outputs)" is necessary.
| @@ -136,10 +123,9 @@ function openInNewWindow() { | |||
| floatingWindow.open(url); | |||
| } | |||
|
|
|||
| function mouseoverPort(event) { | |||
| function mouseoverPort(event: MouseEvent, portDirection: 'input' | 'output') { | |||
There was a problem hiding this comment.
I wonder if that portDirection would be better to be an enum to avoid typing issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screen.Recording.2023-11-20.at.6.35.36.PM.mov