Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tweaks to operator outputs #2296

Merged
merged 2 commits into from
Nov 22, 2023
Merged

refactor: tweaks to operator outputs #2296

merged 2 commits into from
Nov 22, 2023

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Nov 22, 2023

Description

Addressing @YohannParis comments from after the merge #2276

Instead of using isEmpty I do a display: none for inputs/outputs when they are empty since they add there own padding/margin regardless

Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

@shawnyama shawnyama merged commit 292f3a4 into main Nov 22, 2023
5 checks passed
@shawnyama shawnyama deleted the op-outputs-improve branch November 22, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants