Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg sciml simulate #2932

Merged
merged 7 commits into from
Mar 6, 2024
Merged

reorg sciml simulate #2932

merged 7 commits into from
Mar 6, 2024

Conversation

mwdchang
Copy link
Member

@mwdchang mwdchang commented Mar 5, 2024

Summary

This covers the Simulate operators, Calibrate and Ensemble will be dealt with in different PRs.

There are two themes to the PR here

  • Reorganization and simplification of the operator logic, we no longer need to support multiple concurrent simulations within the same operator, and this means we can simplify state management and remove logic that never quite worked completely.
  • Enable a preview on the workflow within the operator node, the nodes will poll and update in a similar manner as the drilldown.

@mwdchang mwdchang requested a review from YohannParis as a code owner March 5, 2024 23:31
Copy link
Member

@YohannParis YohannParis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work if the workflow is still running on the background when the drilldown is open, but if in the future we open those drilldowns in their own tab/window, we loose the Poller updates.

We have ClientEvent already available, listen to that with a Poller in the hmi-server? So now it doesn't matter where you are in the application.

@mwdchang mwdchang merged commit 69969b8 into main Mar 6, 2024
5 checks passed
@mwdchang mwdchang deleted the reorg-simulate-operators branch March 6, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants